From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 77C461F406 for ; Thu, 18 Jan 2018 06:20:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbeARGUQ (ORCPT ); Thu, 18 Jan 2018 01:20:16 -0500 Received: from mail-qt0-f174.google.com ([209.85.216.174]:35785 "EHLO mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835AbeARGUP (ORCPT ); Thu, 18 Jan 2018 01:20:15 -0500 Received: by mail-qt0-f174.google.com with SMTP id u10so27698240qtg.2 for ; Wed, 17 Jan 2018 22:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=h0WU2mApWaDtCovScSaNwMfBMwx+MyKEcAla70xy3Io=; b=liSguIcsjY+19itfZVH8RHyUDli1lYzj+wgMkypANK2YLe7eJs0Ery8vrGpwB6Mz6m PmaUU8oBHvjSdFZc8ZbXqbC42jDGwMFQHjHdbJPhLVTFjllOSrs3ANJdlmPP0n1BD1bK GB1mPBeaTfgvXVlqNwzaVF1e3GseZx3zdSn9s/u/5IOenqyv/n/+AtMpxJsNt787wb9u BQf8/2N3uUdkChXHJM4qFt9XdxNCKFyLUkfSyu5XRmaB3lLSuiHLvdFsQYxXDxX2stVs x2lM7ZkOb4+5D1a3WCMAQe4EA6prr3BXEfszJJfUNemtcjfxxBHXzBUVhyc3YUVwjySW apdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=h0WU2mApWaDtCovScSaNwMfBMwx+MyKEcAla70xy3Io=; b=jTQ6waVyYvBKygBB1APAhhdO9LNqrr1G9FvPTHdTCkQdaD+TCa5dOJLxs/tIBAS3Ks 3Ig87fyBNcRfcN7sly3GfUGNm2mVSJGgT0oiZEbxBkGYwMEqTIL8qb6VDdaKlUVWel2I dOA5ECcU8IJRKUyp2f6VTK91Qa4k0kEdFedvny5dMVdR8LQ/AbRhY6ryULSW+yueOp57 WfSxxeNMm+qeBXTOKnoufZHJADPhTPZbrLtU2MWXcOwSUSblZYsUvwjiaKBfg+QU6m/1 2Wjc1PT0REJlEocqwsAUTTfI+AEplmI1YXInEbfH7xg9OCT11UN7qS2cxstTdvYU2tBQ 8STw== X-Gm-Message-State: AKwxytd3YatQBb4T1sSZb8YvytWig/o7hI3pIxNYNXZ/VLodiQB6HQvH HjWLOdzfnsaEr4II4ZZ0HkoOLEvO5y48El5l4Fs= X-Google-Smtp-Source: ACJfBosEzUJmXwKoWZugqrBND+9iEBMjFZkuyNo0Mli3081ExySRWH6x9hsYZEzv1VZ1ftwqWZOAlk08PuL6CqXkmhg= X-Received: by 10.237.58.132 with SMTP id o4mr38968870qte.207.1516256414836; Wed, 17 Jan 2018 22:20:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.16.146 with HTTP; Wed, 17 Jan 2018 22:20:14 -0800 (PST) In-Reply-To: References: <01020160df6dc499-0e6d11ec-1dcd-4a71-997b-ea231f33fae4-000000@eu-west-1.amazonses.com> <01020160df6dc529-fae54bd6-e595-44fa-9f9a-c44cb3a5a1a8-000000@eu-west-1.amazonses.com> <20180115214208.GD4778@sigill.intra.peff.net> <20180117214354.GA13128@sigill.intra.peff.net> From: =?UTF-8?B?0J7Qu9GPINCi0LXQu9C10LbQvdCw0Y8=?= Date: Thu, 18 Jan 2018 09:20:14 +0300 Message-ID: Subject: Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter To: Christian Couder Cc: Jeff King , git Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org 2018-01-18 1:39 GMT+03:00 Christian Couder : > On Wed, Jan 17, 2018 at 10:43 PM, Jeff King wrote: >> On Tue, Jan 16, 2018 at 09:55:22AM +0300, =D0=9E=D0=BB=D1=8F =D0=A2=D0= =B5=D0=BB=D0=B5=D0=B6=D0=BD=D0=B0=D1=8F wrote: >> >>> > IOW, the progression I'd expect in a series like this is: >>> > >>> > 1. Teach ref-filter.c to support everything that cat-file can do. >>> > >>> > 2. Convert cat-file to use ref-filter.c. >>> >>> I agree, I even made this and it's working fine: >>> https://github.com/git/git/pull/450/commits/1b74f1047f07434dccb207534d1= ad45a143e3f2b > > (Nit: it looks like the above link does not work any more, but it > seems that you are talking about the last patch on the catfile > branch.) > >>> But I decided not to add that to patch because I expand the >>> functionality of several commands (not only cat-file and >>> for-each-ref), and I need to support all new functionality in a proper >>> way, make these error messages, test everything and - the hardest one >>> - support many new commands for cat-file. As I understand, it is not >>> possible unless we finally move to ref-filter and print results also >>> there. Oh, and I also need to rewrite docs in that case. And I decided >>> to apply this in another patch. But, please, say your opinion, maybe >>> we could do that here in some way. >> >> Yeah, I agree that it will cause changes to other users of ref-filter, >> and you'd need to deal with documentation and tests there. But I think >> we're going to have to do those things eventually (since supporting >> those extra fields everywhere is part of the point of the project). And >> by doing them now, I think it can make the transition for cat-file a lot >> simpler, because we never have to puzzle over this intermediate state >> where only some of the atoms are valid for cat-file. > > I agree that you will have to deal with documentation and tests at one > point and that it could be a good idea to do that now. > > I wonder if it is possible to add atoms one by one into ref-filter and > to add tests and documentation at the same time, instead of merging > cat-file atoms with ref-filter atoms in one big step. > > When all the cat-file atoms have been added to ref-filter's > valid_atom, maybe you could add ref-filter's atoms to cat-file's > valid_cat_file_atom one by one and add tests and documentation at the > same time. > > And then when ref-filter's valid_atom and cat-file's > valid_cat_file_atom are identical you can remove cat-file's > valid_cat_file_atom and maybe after that rename "ref-filter" to > "format". I think it's important to finish migrating process at first. I mean, now we are preparing and collecting everything in ref-filter, but we make resulting string and print still in cat-file. And I am not sure, but maybe it will not be possible to start using new atoms in cat-file while some part of logic still differs. And another thoughts here - we were thinking about creating format.h but decided not to move forward with it, and now we are suffering because of it. Can I create it right now or the history of commits would be too dirty because of it? Also, do you mean just renaming of ref-filter? I was thinking that I need to put formatting-related logic to another file and leave all other stuff in ref-filter. Anyway, your suggested steps looks good, and I am planning to implement them later. Let's discuss, what behavior we are waiting for when atom seems useless for the command. Die or ignore? And, which atoms are useless (as I understand, "rest" and "deltabase" from cat-file are useless for all ref-filter users, so the question is about - am I right in it, and about ref-filter atoms for cat-file). I have never written any tests and docs for Git, I will try to explore by myself how to do that, but if you have any special links/materials about it - please send them to me :) Olga