git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
* [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic
@ 2018-03-29 12:52 Оля Тележная
  2018-03-29 14:41 ` Christian Couder
  0 siblings, 1 reply; 4+ messages in thread
From: Оля Тележная @ 2018-03-29 12:52 UTC (permalink / raw)
  To: git

Move helper function from strbuf to ref-filter.
Get rid of some memory leaks.

Thanks to everyone!
Olga

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic
  2018-03-29 12:52 [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic Оля Тележная
@ 2018-03-29 14:41 ` Christian Couder
  2018-03-30  0:16   ` Eric Sunshine
  2018-03-30  6:42   ` Оля Тележная
  0 siblings, 2 replies; 4+ messages in thread
From: Christian Couder @ 2018-03-29 14:41 UTC (permalink / raw)
  To: Оля
	Тележная
  Cc: git

On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:
> Move helper function from strbuf to ref-filter.
> Get rid of some memory leaks.

The above seems to be the changes since v5. Usually in a cover letter
(patch 0/X) there is both information about the goal of the patch
series and the changes since last version.

Repeating the goal in each version is useful for reviewers who might
not have time to look at the patch series before, or who might have
forgotten about it.

Thanks,
Christian.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic
  2018-03-29 14:41 ` Christian Couder
@ 2018-03-30  0:16   ` Eric Sunshine
  2018-03-30  6:42   ` Оля Тележная
  1 sibling, 0 replies; 4+ messages in thread
From: Eric Sunshine @ 2018-03-30  0:16 UTC (permalink / raw)
  To: Christian Couder
  Cc: Оля
	Тележная,
	git

On Thu, Mar 29, 2018 at 10:41 AM, Christian Couder
<christian.couder@gmail.com> wrote:
> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:
>> Move helper function from strbuf to ref-filter.
>> Get rid of some memory leaks.
>
> The above seems to be the changes since v5. Usually in a cover letter
> (patch 0/X) there is both information about the goal of the patch
> series and the changes since last version.
>
> Repeating the goal in each version is useful for reviewers who might
> not have time to look at the patch series before, or who might have
> forgotten about it.

Another important way to help both returning and new reviewers is to
provide a link to the previous iteration (or iterations), like
this[1].

Thanks.

[1]: https://public-inbox.org/git/0102016249d21c40-0edf6647-4d26-46fc-8cfd-5a446b93a5e2-000000@eu-west-1.amazonses.com/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic
  2018-03-29 14:41 ` Christian Couder
  2018-03-30  0:16   ` Eric Sunshine
@ 2018-03-30  6:42   ` Оля Тележная
  1 sibling, 0 replies; 4+ messages in thread
From: Оля Тележная @ 2018-03-30  6:42 UTC (permalink / raw)
  To: Christian Couder; +Cc: git

2018-03-29 17:41 GMT+03:00 Christian Couder <christian.couder@gmail.com>:
> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:
>> Move helper function from strbuf to ref-filter.
>> Get rid of some memory leaks.
>
> The above seems to be the changes since v5. Usually in a cover letter
> (patch 0/X) there is both information about the goal of the patch
> series and the changes since last version.
>
> Repeating the goal in each version is useful for reviewers who might
> not have time to look at the patch series before, or who might have
> forgotten about it.

Thank you, I wasn't thinking about it that way. I agree, it's important.

Description:
The main idea of the patch is, if you want to format the output by
ref-filter, you should have an ability to work with errors and final
message by yourself if you want to.
So I decided not to touch signature of show_ref_array_item(), but to
move all die() invocations to it. So that we could invoke
format_ref_array_item() and be sure that we could handle errors by
ourselves, and we also get formatted message so we could continue
working with it if we want to.

Thank you,
Olga

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-03-30  6:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-29 12:52 [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic Оля Тележная
2018-03-29 14:41 ` Christian Couder
2018-03-30  0:16   ` Eric Sunshine
2018-03-30  6:42   ` Оля Тележная

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git