* [PATCH] ref-filter: mark some file-local symbols as static
@ 2018-07-12 15:57 Ramsay Jones
2018-07-12 17:07 ` Оля Тележная
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2018-07-12 15:57 UTC (permalink / raw)
To: Olga Telezhnaya; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Olga,
If you need to re-roll your 'ot/ref-filter-object-info' branch,
could you please squash this into the relevant patch (commit c5d9a471d6,
"ref-filter: use oid_object_info() to get object", 2018-07-09).
[Both sparse and my static-check.pl script are complaining about
the 'oi' and 'oi_deref' symbols.]
Thanks!
ATB,
Ramsay Jones
ref-filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ref-filter.c b/ref-filter.c
index 9aedf29e0..70fb15619 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -63,7 +63,7 @@ struct refname_atom {
int lstrip, rstrip;
};
-struct expand_data {
+static struct expand_data {
struct object_id oid;
enum object_type type;
unsigned long size;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ref-filter: mark some file-local symbols as static
2018-07-12 15:57 [PATCH] ref-filter: mark some file-local symbols as static Ramsay Jones
@ 2018-07-12 17:07 ` Оля Тележная
0 siblings, 0 replies; 2+ messages in thread
From: Оля Тележная @ 2018-07-12 17:07 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
2018-07-12 18:57 GMT+03:00 Ramsay Jones <ramsay@ramsayjones.plus.com>:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Olga,
>
> If you need to re-roll your 'ot/ref-filter-object-info' branch,
> could you please squash this into the relevant patch (commit c5d9a471d6,
> "ref-filter: use oid_object_info() to get object", 2018-07-09).
>
> [Both sparse and my static-check.pl script are complaining about
> the 'oi' and 'oi_deref' symbols.]
You are right. Thanks a lot!
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> ref-filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ref-filter.c b/ref-filter.c
> index 9aedf29e0..70fb15619 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -63,7 +63,7 @@ struct refname_atom {
> int lstrip, rstrip;
> };
>
> -struct expand_data {
> +static struct expand_data {
> struct object_id oid;
> enum object_type type;
> unsigned long size;
> --
> 2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-12 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 15:57 [PATCH] ref-filter: mark some file-local symbols as static Ramsay Jones
2018-07-12 17:07 ` Оля Тележная
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).