From: Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>
To: git@vger.kernel.org
Subject: git-p4 crashes on non UTF-8 output from p4
Date: Thu, 8 Apr 2021 12:28:25 -0700 [thread overview]
Message-ID: <CAKu1iLXtwuCQTS0s7_LEm0OJF-4s0UhPhDW1r5Zb7=GsSPfpdQ@mail.gmail.com> (raw)
When git-p4 reads the output from a p4 command, it assumes it will be
100% UTF-8. If even one character in the output of one p4 command is
not UTF-8, git-p4 crashes with:
File "C:/Program Files/Git/bin/git-p4.py", line 774, in p4CmdList
value = value.decode() UnicodeDecodeError: 'utf-8' codec can't
decode byte Ox93 in position 42: invalid start byte
I'd like to make a pull request to have it try another encoding (eg
cp1252) and/or use the Unicode replacement character, to prevent the
whole program from crashing on such a minor problem.
This is especially a problem on the "git p4 clone" command with @all,
where git-p4 needs to read thousands of changeset descriptions, one of
which may have a stray smart quote, causing the whole clone operation
to fail.
Sound ok?
next reply other threads:[~2021-04-08 19:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 19:28 Tzadik Vanderhoof [this message]
2021-04-09 15:38 ` git-p4 crashes on non UTF-8 output from p4 Torsten Bögershausen
2021-04-11 7:16 ` Tzadik Vanderhoof
2021-04-11 9:37 ` Torsten Bögershausen
2021-04-11 20:21 ` Tzadik Vanderhoof
2021-04-12 4:06 ` Torsten Bögershausen
2021-04-21 8:46 ` [PATCH] add git-p4.fallbackEncoding config variable, to prevent git-p4 from crashing on non UTF-8 changeset descriptions Tzadik Vanderhoof
2021-04-21 8:55 ` Tzadik Vanderhoof
2021-04-22 5:05 ` [PATCH v3] add git-p4.fallbackEncoding config setting, " Tzadik Vanderhoof
2021-04-22 15:50 ` Torsten Bögershausen
2021-04-22 16:17 ` Eric Sunshine
2021-04-22 22:33 ` Eric Sunshine
2021-04-23 6:36 ` [PATCH] add git-p4.fallbackEncoding config variable, " Tzadik Vanderhoof
2021-04-23 6:44 ` Tzadik Vanderhoof
2021-04-23 19:08 ` Tzadik Vanderhoof
2021-04-24 8:14 ` Torsten Bögershausen
2021-04-27 5:39 ` [PATCH v5] " Tzadik Vanderhoof
2021-04-27 5:45 ` Tzadik Vanderhoof
2021-04-28 4:39 ` Junio C Hamano
2021-04-28 14:58 ` Torsten Bögershausen
2021-04-29 7:39 ` [PATCH v6] Add git-p4.fallbackEncoding Tzadik Vanderhoof
2021-04-29 8:36 ` Luke Diamand
2021-04-29 17:29 ` Tzadik Vanderhoof
[not found] ` <20210429074458.891-1-tzadik.vanderhoof@gmail.com>
[not found] ` <c4c48615-d1f4-fd37-0960-979535907f15@web.de>
2021-04-29 17:14 ` Tzadik Vanderhoof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKu1iLXtwuCQTS0s7_LEm0OJF-4s0UhPhDW1r5Zb7=GsSPfpdQ@mail.gmail.com' \
--to=tzadik.vanderhoof@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).