From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 19DE21F8C1 for ; Wed, 6 May 2020 18:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730382AbgEFSnj (ORCPT ); Wed, 6 May 2020 14:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729895AbgEFSnj (ORCPT ); Wed, 6 May 2020 14:43:39 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1582FC061A0F for ; Wed, 6 May 2020 11:43:39 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id f83so3199725qke.13 for ; Wed, 06 May 2020 11:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qvbkFHR9Pb1jDIG7mruOxSuSkT+eoJrP9FFirxfNIlc=; b=rob8j688BwcVd7G6JPIek/PMP/hv1Y+GBr0SQLBkT11GnbV4tAZfsUWeWVJO15OvW7 Ofk90GC3Mrw38H32GVaNP3BJNRbopwRAID2824ekyFSRZ/nADRbT8yLnGSEQpNsgm++h iPqfY3v7SBCzC8SDO8F3/n7AwNxKzZv/m79UycBb4ft0Hg7zf9K+8Mqa9EpY/SzdEO2x j0mp2PBOyTifSKh3FtC37TkekR4l/xRLpZM+wXfMi7JA8ClcKGHmOnCCNXdVMWorEeW8 1a6AxBlx8CMx0LxtfQkbVNVnimTQWTdEvN89fRd0MafbcCZU41JJqKhABkpWdfTLjqJq +4Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qvbkFHR9Pb1jDIG7mruOxSuSkT+eoJrP9FFirxfNIlc=; b=f97qBIn6YxzxSICUVe/7mVwcerACwSWxL0OY5tb1d0npmrdm+h6Lefeslr44OYIZsV Euq8A52h+bFrhKDTKd9U0xGMz4LV8m3K4evF0nh8lacDDkmUBkYMn65LLyB5gHPQnjlQ rSWhY/ba+FcaXu4PJ+IOj5ieMORgt32v2N7Xwykemti3fYfAKBq6nsyZYymosgPObihO aa54HzcM2F/2ZywCLH6gq9ek42BecWkWUIoBgrnkMVIG6/UrCSZI5gUi34sIVZrhlvsl tsg2Y2fBfJ5KFZjsI16c1k7Iz1CwTjMemhMumF+XbeQGBdXlRMYQ/L8reVM1MGADF91w NX2w== X-Gm-Message-State: AGi0Pubz7mwi/bCxx+FTKg3IIhjR1C4leYfRiOf4ZHQLKk7Cvld/CYc3 oejAVllmSFGg1kr6qLfT+oTZlYxWMI33dGlTq0w= X-Google-Smtp-Source: APiQypJqmKmOFDgU8i9NJO0OzbMEjAHz9aOEO2BMgCHV8PxKO4BqNbSyuPbp+uXNqyIw4MO5C20UaXuzviyypCkoy3s= X-Received: by 2002:a37:6c07:: with SMTP id h7mr10312018qkc.328.1588790617381; Wed, 06 May 2020 11:43:37 -0700 (PDT) MIME-Version: 1.0 References: <20200427200852.GC1728884@coredump.intra.peff.net> <20200427201228.GD1728884@coredump.intra.peff.net> <20200428135222.GB31366@danh.dev> <20200428210750.GE4000@coredump.intra.peff.net> <689741588534833@mail.yandex.ru> <848941588629532@mail.yandex.ru> In-Reply-To: From: Sibi Siddharthan Date: Thu, 7 May 2020 00:13:25 +0530 Message-ID: Subject: Re: [PATCH 0/8] CMake build system for git To: Junio C Hamano Cc: Konstantin Tokarev , Johannes Schindelin , Jeff King , Danh Doan , Sibi Siddharthan via GitGitGadget , "git@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, May 5, 2020 at 11:47 PM Junio C Hamano wrote: > > Sibi Siddharthan writes: > > > I have made the following changes as suggested: > > 1) The CMake script works from contrib/cmake now. > > 2) The CMake script parses the Makefile for > > SCRIPT_SH > > SCRIPT_PERL > > TEST_BUILTINS_OBJS > > LIB_OBJS > > BUILTIN_OBJS > > XDIFF_OBJS > > VCSSVN_OBJS > > 3) Philip suggested to change the error message if sh/bash was not > > found on windows. > > 4) CMake now tests for ICONV_OMITS_BOM, NO_ST_BLOCKS_IN_STRUCT_STAT. > > > > Regarding the commits, since 1,2,4 are additions to the script, is it > > acceptable for those changes to be staged in the next commits? > > I am not sure what you exactly mean by "to be staged in the next > commits". But as a new topic (from the point of view of the general > public), please avoid adding a known-broken one in patch 1 and then > following up with a series of "oops, that was wrong and here is to > fix the breakage" patches. > > On the other hand, if the final contents added by the resulting > topic is easier to explain and review if built incrementally in > logical steps, please do so. In other words, a series of follow up > "now we have basics there, teach the machinery to do this, too" > patches is perfectly fine, as opposed to "oops, that was wrong and > here is to fix". > 2 and 4 are additions to the capability of the script, which means they have to be added as separate commits (between 7/8 and 8/8). 3 is clearly an edit (fixup 6/8) I am confused for 1 though. I think it would be better to add it as a new commit (between 7/8 and 8/8). Is this acceptable? Thank You, Sibi Siddharthan > > Regarding the workflow file(main.yml), I modified the vs-build and > > test steps, should I drop the commit or should I keep the changes(a > > modification is further needed if CMake is going to be used for > > vs-build) > > It sounds like an integral part of the end result we would want to > get out of this series, so if that is the case, I do not see a > reason to exclude it. > > Thanks.