From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 790CD1F55B for ; Wed, 13 May 2020 20:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390758AbgEMUI1 (ORCPT ); Wed, 13 May 2020 16:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2387445AbgEMUI1 (ORCPT ); Wed, 13 May 2020 16:08:27 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88C89C061A0C for ; Wed, 13 May 2020 13:08:25 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id f83so622879qke.13 for ; Wed, 13 May 2020 13:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dsdJwVfyQFGQ+UlTf87byM5AKBj0qpXhTmL6uD8x+NU=; b=sH+cncxIaekiY14sjLDZULYcB28ODKPxFKdbackZ3MuCSKZwJWUohGfcfgCSMGTs+l lSkkUtBJ2FzsfxucPSVLX++ptBC3bv1JdBPF1pFPOB+xpLK5aqq08e9GNEu+tEyxvc9j mlNWU5Z1cYTkCzx8kXqdgAXd5qsvbG9hDGeZzeYL6uJvPyGjDZg7Iz8C78a9xW5Vzqyq ybfGCXuZTnXd+SAd4t8OcEvCPerq67U5lagXqPhTlOTSDUvFVA6Sb8eN3j32gJkUfCWO +IUhhrD/8f10m7ONFTQ+uKALmxY+7YM12U4Z3vVCMQ7cQc+lhtoNVZtzbVVpZd449oM6 tn7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dsdJwVfyQFGQ+UlTf87byM5AKBj0qpXhTmL6uD8x+NU=; b=CBbrIHv+A6HUoeO4YwKAtoMcO7AbaKMNf9lOiQ5EUvWsaYmgrFjnd3muxBpLroDeW2 aI9d4fmXpTgSEjIoKhpCA/DBNY+oap+JxbbQotPHf/bTMSneed6pA4nXaHVr9Luz7Qtw rKQpfEaVqNNMyPEtNILdnhL4sYYT4O+Mnvz16Fgs4FRHVaBOXXlKBLypHAL+XFWRJoYZ XgfPXH2pq4uOGCYkxoYKRhMMGdc2Umy6SkyWHFBTHRAWfwQ8wDO2X2Kr3iQi8H9Ncqkp XIUnm4ok81bxuqhjcbdplWfpwPCHkyc0rg7j2ppSg6rGUDTgd75mmKn0Kv0CCl7Nh7iy afbQ== X-Gm-Message-State: AOAM530OdcQFt/CM+NqGgIDN5qgP2k550EJrLdUsV7lRT6nrKS9gneWH kmrL2pWcX9+MwQ1Y4KRDAYM2J/ybWnYdftuhE4s= X-Google-Smtp-Source: ABdhPJzCu3ZON9qrrAZxKnR18uXJG2oGAWCpA14L7/LswTlsDiFPWlPheBKhF0E95HFwhC6A42/PD/UMYpu9kDmDrg8= X-Received: by 2002:a37:49cb:: with SMTP id w194mr1390790qka.77.1589400504823; Wed, 13 May 2020 13:08:24 -0700 (PDT) MIME-Version: 1.0 References: <9c674372fb58aa42e339c0a96c432283c4b0a894.1589302255.git.gitgitgadget@gmail.com> In-Reply-To: From: Sibi Siddharthan Date: Thu, 14 May 2020 01:38:15 +0530 Message-ID: Subject: Re: [PATCH v2 09/11] cmake: relocated script file contrib/buildsystems To: Junio C Hamano Cc: Sibi Siddharthan via GitGitGadget , git@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, May 13, 2020 at 2:40 AM Junio C Hamano wrote: > > "Sibi Siddharthan via GitGitGadget" writes: > > > From: Sibi Siddharthan > > > > The CMake script has been relocated to contrib/buildsystems. > > The changes made to the script involves pointing to correct location > > of the source files. > > This does match what the list agreed to do. Why isn't this done as > part of [01/11]? If there is no technical reason not to, I'd > strongly prefer to see it done from the very beginning. The same > comment applies to the next step. Okay > > Thanks. > > > Signed-off-by: Sibi Siddharthan > > --- > > .../buildsystems/CMakeLists.txt | 76 +++++++++++-------- > > 1 file changed, 45 insertions(+), 31 deletions(-) > > rename CMakeLists.txt => contrib/buildsystems/CMakeLists.txt (92%)