From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id C0E701F403 for ; Sat, 25 Jun 2022 02:31:49 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=bytedance-com.20210112.gappssmtp.com header.i=@bytedance-com.20210112.gappssmtp.com header.b="eN3nnkjN"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231434AbiFYCbc (ORCPT ); Fri, 24 Jun 2022 22:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230224AbiFYCbb (ORCPT ); Fri, 24 Jun 2022 22:31:31 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A84944A30 for ; Fri, 24 Jun 2022 19:31:31 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id x184so4673092ybg.12 for ; Fri, 24 Jun 2022 19:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LOs0+jP5EvWCEjiRklv+w0uoW8YEVYn6YuhC/Np6+Pg=; b=eN3nnkjNT3UFp61oUjf4dWVW9o/JyhoGeo178szC49E6ZXLb2Efg+TJ99UW6107JF2 3HIrfHNzDanugyAarFWxcs7xIzPmJX/iI4L7rQMhSSz6eB4OLVj/WatEgzG/vld8jtOw TWShhZJpwnoCRAghJLL8G8OgT29kC+m4lN9DPNpXtqySnXacZbUtCXg92SDIX3ErkOj8 xetJkojaffU7uVbT6CSei+0gSahk+jOyeoHLV8O6EeJJ43mJ0HVbIoXgjrWpKhwrz/fx nZsVaT+UBV+TmDtxbe01BNsGWx0ZlB/0f61ErfFNxJwkCoI2JoECMVgFWXpnO/I2MKaY ZMrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LOs0+jP5EvWCEjiRklv+w0uoW8YEVYn6YuhC/Np6+Pg=; b=D5D1cN9t9jrgxd0FqztM5eGcOO3mTuwuJQ3JVtuyRM3/uLMPU1bmKclgNTGyucWOoU 8QpmDMiD5gsJ+giX+UMtd1cKA9wgLzTxonO7NxEHkVLHAWfzSDbMgAzuvIZmZ4PQKcUN 29hX0/KCsTVlXvpS203QUZhxaP3e7hxHyUIxBu5InDRdriqYyXTnw3BTCsX2bvCvtvWt XiYKmNUiyhMK4c/G6/WKzKO2drxML0p2KZgKCPVFMA2NL3R4U0zjBLV43ufYY9UYLwU+ +TJgBqgZBt25QD3C1IWqW867ho4lM6+Ke+KhIr95umDRzU0c9h77ZESnAQmuppe3KR+K A58A== X-Gm-Message-State: AJIora8ySi0kQ3up7BaqQbGX74mGXPNjp6NVj6eM4cAbZh/R9JFXffME oYg4X3mlXT3mbkQOqNAh6OsxBMWZXsBf9MG6H0f8TA== X-Google-Smtp-Source: AGRyM1vBdHJ4gSZHENzNrSpTrogdVwo5YBr4tF6Qhj1PmhqCjCc4YaGtlbz7SW2JCdG9NnqwrToBdB/sdc+oECnu8+E= X-Received: by 2002:a25:3c45:0:b0:664:cf75:c2d6 with SMTP id j66-20020a253c45000000b00664cf75c2d6mr2206300yba.446.1656124290390; Fri, 24 Jun 2022 19:31:30 -0700 (PDT) MIME-Version: 1.0 References: <20220618030130.36419-1-hanxin.hx@bytedance.com> In-Reply-To: From: Han Xin Date: Sat, 25 Jun 2022 10:31:19 +0800 Message-ID: Subject: Re: Re: [PATCH v2 2/2] commit-graph.c: no lazy fetch in lookup_commit_in_graph() To: Junio C Hamano Cc: chiyutianyi@gmail.com, derrickstolee@github.com, git@vger.kernel.org, haiyangtand@gmail.com, Jonathan Tan , Taylor Blau , Patrick Steinhardt Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Jun 25, 2022 at 10:25 AM Han Xin wrote: > > The "bug" depends on the commit exist in the commit-graph but > missing in the repository. > > I didn't find a better way to make this kind of scene. > > This bug was first found when alternates and commit-graph were > both used. Since the promise did not maintain all the references, > I suspect that the "auto gc" during the update process of the promise > caused the loss of the unreachable commits in the promise. > Some mistakes here: This bug was first found when alternates and commit-graph were both used. Since the promise did not maintain all the references, I suspect that the "auto gc" during the update of the alternates caused the loss of the unreachable commits.