From: Bert Wesarg <bert.wesarg@googlemail.com>
To: David <bouncingcats@gmail.com>
Cc: Birger Skogeng Pedersen <birger.sp@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: feature request, git-gui: add hotkey to toggle amend/new
Date: Tue, 3 Sep 2019 10:44:45 +0200 [thread overview]
Message-ID: <CAKPyHN3S60U8jODeDaVimstF_GkmCCFqDn-AM=urgqKqUnJmAA@mail.gmail.com> (raw)
In-Reply-To: <CAMPXz=pUWNVkM78UHm4NpFZ_nJQOa0ba07N3gMKFzWUiindZ1Q@mail.gmail.com>
David,
On Tue, Sep 3, 2019 at 3:01 AM David <bouncingcats@gmail.com> wrote:
>
> On Tue, 3 Sep 2019 at 04:11, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> > On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen <birger.sp@gmail.com> wrote:
> > > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen <birger.sp@gmail.com> wrote:
>
> > > > In my pursuit to fully utilize git-gui with only using a keyboard, I
> > > > suggest that there is a hotkey to toggle between selecting "New
> > > > Commit" and "Amend Last Commit".
>
> Hi, thanks for maintaining and contributing to git and git-gui, it's a
> great tool!
>
> > After focusing the commit message widget, you can focus the radio
> > buttons with Tab/Shift+Tab and press Space.
>
> > I think this is short enough, so that wasting a Letter is not
> > justified here.
>
> Ugh, may I express how unhappy I am to read that opinion from
> the maintainer. I strongly disagree, please reconsider :(
>
> And I enthusiastically support this initial request for a single
> hotkey to immediately toggle between "New Commit" and "Amend Last
> Commit". And it should work regardless of wherever the cursor or
> highlight is currently active.
>
> I have used git-gui for many years and I find this is actually the
> most annoying and inconsistent aspect of its user interface. Sometimes
> if one is lucky then "spacebar" will achieve it at startup or after
> refresh, sometimes not. When I test here just now the suggested
> tab/shift-tab/spacebar method, it does toggle but it also changes the
> items in the staged changes list as an unwanted side effect. My
> version says 0.20.0.8.gd000, but I have a few local patches (written
> years ago) so sorry I am not testing with a version that you have, but
> even so I wanted to report what I observed.
>
> If one is often amending commit messages as I do during large
> interactive rebases, it is painful to have to do some kind of
> context-sensitive multi-key dance just to change from "New Commit" to
> "Amend Last Commit". Especially when every other operation has become
> a single keystroke in my muscle memory.
>
> In my world it most definitely would not be "wasting a letter" to
> implement this! It would instead be "OMG at last that got fixed for
> everyone, hooray!" :D
thanks for the input. Though I'm not the maintainer.
Bert
prev parent reply other threads:[~2019-09-03 8:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 10:51 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
2019-09-02 16:25 ` Birger Skogeng Pedersen
2019-09-02 18:07 ` Bert Wesarg
2019-09-02 19:49 ` Birger Skogeng Pedersen
2019-09-02 19:56 ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-03 8:52 ` Bert Wesarg
2019-09-03 10:25 ` Bert Wesarg
2019-09-03 16:20 ` Bert Wesarg
2019-09-02 20:12 ` feature request, git-gui: add hotkey to toggle amend/new Bert Wesarg
2019-09-02 20:15 ` Bert Wesarg
2019-09-03 5:37 ` Birger Skogeng Pedersen
2019-09-03 12:45 ` Pratyush Yadav
2019-09-03 14:06 ` Birger Skogeng Pedersen
2019-09-03 17:34 ` Pratyush Yadav
2019-09-03 15:35 ` David
2019-09-03 17:27 ` Pratyush Yadav
2019-09-04 6:24 ` Johannes Sixt
2019-09-04 17:46 ` Pratyush Yadav
2019-09-04 17:54 ` Birger Skogeng Pedersen
2019-09-04 18:52 ` Johannes Sixt
2019-09-04 19:03 ` Bert Wesarg
2019-09-10 8:54 ` David Aguilar
2019-09-11 10:27 ` Birger Skogeng Pedersen
2019-09-11 18:34 ` Pratyush Yadav
2019-09-11 18:47 ` Pratyush Yadav
2019-09-03 1:01 ` David
2019-09-03 8:44 ` Bert Wesarg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKPyHN3S60U8jODeDaVimstF_GkmCCFqDn-AM=urgqKqUnJmAA@mail.gmail.com' \
--to=bert.wesarg@googlemail.com \
--cc=birger.sp@gmail.com \
--cc=bouncingcats@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).