From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Birger Skogeng Pedersen <birger.sp@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: git-gui: Long lines in commit message gets hidden, no scrollbar appears
Date: Mon, 2 Sep 2019 19:58:29 +0200 [thread overview]
Message-ID: <CAKPyHN3FYR0FbDxnE4ru7OoK4w3OEE0g8tpoOqH-e+e1iTmcuA@mail.gmail.com> (raw)
In-Reply-To: <xmqqa7bmvbwz.fsf@gitster-ct.c.googlers.com>
On Mon, Sep 2, 2019 at 7:35 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Bert Wesarg <bert.wesarg@googlemail.com> writes:
>
> > the old reasoning was, that you should not create commit messages
> > which are too wide.
>
> True, and that reasoning would justify hiding scrollbar when not
> necessary to gain vertical space. Can we arrange the scrollbar to
> appear only when needed?
up to now, git-gui does not hide any scrollbars, if they are not
needed. IMHO, I would keep it that way, as I don't like the flicker
when it appears and disappears. Imagine you are typing in the bottom
line and than you typed too much. The scrollbar appears, your input
line jumps one up line (or is hidden behind the scrollbar), than you
remove the too long line, the scrollbar disappears again and your
input line jumps down again.
Bert
next prev parent reply other threads:[~2019-09-02 17:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 9:11 git-gui: Long lines in commit message gets hidden, no scrollbar appears Birger Skogeng Pedersen
2019-09-02 12:05 ` Bert Wesarg
2019-09-02 17:04 ` Birger Skogeng Pedersen
2019-09-02 18:12 ` Pratyush Yadav
2019-09-02 18:22 ` Birger Skogeng Pedersen
2019-09-02 18:44 ` Pratyush Yadav
2019-09-02 18:58 ` Pratyush Yadav
2019-09-02 19:03 ` Bert Wesarg
2019-09-02 19:13 ` Bert Wesarg
2019-09-02 19:28 ` Birger Skogeng Pedersen
2019-09-03 17:15 ` Pratyush Yadav
2019-09-04 19:39 ` Bert Wesarg
2019-09-04 22:35 ` Pratyush Yadav
2019-09-04 5:42 ` Birger Skogeng Pedersen
2019-09-04 14:04 ` Pratyush Yadav
2019-09-02 17:35 ` Junio C Hamano
2019-09-02 17:58 ` Bert Wesarg [this message]
2019-09-02 18:51 ` Birger Skogeng Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKPyHN3FYR0FbDxnE4ru7OoK4w3OEE0g8tpoOqH-e+e1iTmcuA@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).