From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Pratyush Yadav <me@yadavpratyush.com>,
Birger Skogeng Pedersen <birger.sp@gmail.com>,
Git List <git@vger.kernel.org>, David <bouncingcats@gmail.com>
Subject: Re: feature request, git-gui: add hotkey to toggle amend/new
Date: Wed, 4 Sep 2019 21:03:02 +0200 [thread overview]
Message-ID: <CAKPyHN3+Sr2QJGR7Sw02x0A9OXshVUQofqH=ShXDivmqP5X7vw@mail.gmail.com> (raw)
In-Reply-To: <8a726eea-f461-db90-7e36-70b708ff8915@kdbg.org>
On Wed, Sep 4, 2019 at 8:52 PM Johannes Sixt <j6t@kdbg.org> wrote:
>
> Am 04.09.19 um 19:46 schrieb Pratyush Yadav:
> > On 04/09/19 08:24AM, Johannes Sixt wrote:
> >> That is worth a try. The check box title offers a natural hotkey then:
> >> "_A_mend last commit", Alt-a.
> >
> > Right now, the binding proposed is Ctrl-e. My mental model for the key
> > bindings as of now is having the "actions" bound to Ctrl, and bindings
> > that move you around in the UI bound to Alt. So it makes more sense to
> > me to have a "amend toggle" bound to Ctrl. Maybe that's just me though.
> > Anyone else care to chime in?
>
> "Amend last commit" is NOT an action. It switches a state.
>
> It is common in Windows GUIs that every control, including menu items,
> has a hotkey associated, the underlined letter in the caption, and the
> hotkey to access that UI control is Alt+that letter. It's not
> necessarily a matter of moving around.
>
> And, BTW, this hotkey thing is also the case on my Linux desktop
> (KDE-based).
>
> But of course, git-gui is different and totally off track here. It has
> *zero* controls marked for hotkey-accessibility. I was just hoping to
> spark an effort to make some of the controls marked and hotkey-accessible.
I'm in favor of making this a checkbox, also in the menu. As all menu
entries have currently a CTRL+ binding assigned, I think this one
should have one too. As CTRL+A is taken, and the proposal is CTRL+E, I
would be fine with this. If the menus and the UX elements also honors
mnemonic now or in the future, I don't think they need to match the
CTRL+ binding. Thus if this gets Alt+A I'm fine with this too.
Bert
>
> -- Hannes
next prev parent reply other threads:[~2019-09-04 19:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 10:51 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
2019-09-02 16:25 ` Birger Skogeng Pedersen
2019-09-02 18:07 ` Bert Wesarg
2019-09-02 19:49 ` Birger Skogeng Pedersen
2019-09-02 19:56 ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-03 8:52 ` Bert Wesarg
2019-09-03 10:25 ` Bert Wesarg
2019-09-03 16:20 ` Bert Wesarg
2019-09-02 20:12 ` feature request, git-gui: add hotkey to toggle amend/new Bert Wesarg
2019-09-02 20:15 ` Bert Wesarg
2019-09-03 5:37 ` Birger Skogeng Pedersen
2019-09-03 12:45 ` Pratyush Yadav
2019-09-03 14:06 ` Birger Skogeng Pedersen
2019-09-03 17:34 ` Pratyush Yadav
2019-09-03 15:35 ` David
2019-09-03 17:27 ` Pratyush Yadav
2019-09-04 6:24 ` Johannes Sixt
2019-09-04 17:46 ` Pratyush Yadav
2019-09-04 17:54 ` Birger Skogeng Pedersen
2019-09-04 18:52 ` Johannes Sixt
2019-09-04 19:03 ` Bert Wesarg [this message]
2019-09-10 8:54 ` David Aguilar
2019-09-11 10:27 ` Birger Skogeng Pedersen
2019-09-11 18:34 ` Pratyush Yadav
2019-09-11 18:47 ` Pratyush Yadav
2019-09-03 1:01 ` David
2019-09-03 8:44 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKPyHN3+Sr2QJGR7Sw02x0A9OXshVUQofqH=ShXDivmqP5X7vw@mail.gmail.com' \
--to=bert.wesarg@googlemail.com \
--cc=birger.sp@gmail.com \
--cc=bouncingcats@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).