From: Dhruva Krishnamurthy <dhruvakm@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
Taylor Blau <me@ttaylorr.com>, Jeff King <peff@peff.net>,
John Cai <johncai86@gmail.com>,
git@vger.kernel.org
Subject: Re: using tree as attribute source is slow, was Re: Help troubleshoot performance regression cloning with depth: git 2.44 vs git 2.42
Date: Thu, 2 May 2024 22:37:59 -0700 [thread overview]
Message-ID: <CAKOHPA==xgRBLXmyURkdZ9X4LqQoBHYy=XD0Q_KTQHbK54DOFg@mail.gmail.com> (raw)
In-Reply-To: <xmqqbk5ndiqk.fsf@gitster.g>
On Thu, May 2, 2024 at 2:08 PM Junio C Hamano <gitster@pobox.com> wrote:
> We could drop [1/2] from the series in the meantime to make it a
> GitLab installation specific issue where they explicitly use
> attr.tree to point at HEAD ;-) That is not solving anything for
> those who set attr.tree (in a sense, they are buying the feature
> with overhead of reading attributes from the named tree), but at
> least for most people who are used to seeing the bare repository
> ignoring the attributes, it would be an improvement to drop the
> "bare repositories the tree of the HEAD commit is used to look up
> attributes files by default" half from the series.
>
A hack (without knowing side effects if any) is to use an empty tree
for attr source:
$ git config --add attr.tree $(git hash-object -t tree /dev/null)
This gives me performance comparable to git 2.42
next prev parent reply other threads:[~2024-05-03 5:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 5:26 Help troubleshoot performance regression cloning with depth: git 2.44 vs git 2.42 Dhruva Krishnamurthy
2024-05-01 22:00 ` using tree as attribute source is slow, was " Jeff King
2024-05-01 22:37 ` rsbecker
2024-05-01 22:40 ` Junio C Hamano
2024-05-02 0:33 ` Taylor Blau
2024-05-02 17:33 ` Taylor Blau
2024-05-02 17:44 ` Junio C Hamano
2024-05-02 17:55 ` Taylor Blau
2024-05-02 19:01 ` Karthik Nayak
2024-05-02 21:08 ` Junio C Hamano
2024-05-03 5:37 ` Dhruva Krishnamurthy [this message]
2024-05-03 15:34 ` Re* " Junio C Hamano
2024-05-03 17:46 ` Jeff King
2024-05-06 20:28 ` Taylor Blau
2024-05-13 20:16 ` John Cai
2024-05-02 18:34 ` Dhruva Krishnamurthy
2024-05-02 0:45 ` Dhruva Krishnamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOHPA==xgRBLXmyURkdZ9X4LqQoBHYy=XD0Q_KTQHbK54DOFg@mail.gmail.com' \
--to=dhruvakm@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
--cc=karthik.188@gmail.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).