From: Zoltan Klinger <zoltan.klinger@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4] git-clean: Display more accurate delete messages
Date: Thu, 10 Jan 2013 21:41:56 +1100 [thread overview]
Message-ID: <CAKJhZwQ=RzLgCBUrx_QKY8Xzh-L8QC2UVcQJEpYxxGQz=8LwwQ@mail.gmail.com> (raw)
In-Reply-To: <7vk3rl3fw5.fsf@alter.siamese.dyndns.org>
> I think the code before this patch used to say "Would not remove"
> and "Not removing" in certain cases to report the paths that the
> command decided not to remove, but after this patch these two
> messages no longer appear in the patch.
>
> Is it expected, are we losing information, or...?
>
I do not think we are losing any information.
Say, we have a repo like this:
test.git
|-- untracked_file
|-- untracked_bar
| |-- bar.txt
|-- untracked_foo
|-- foo.txt
The original version prints out:
$ git clean -fn
Would remove untracked_file
Would not remove untracked_bar/
Would not remove untracked_foo/
We never asked for any directories to be removed so IMHO the "Would
not remove ..." messages are just noise.
The new version prints out:
$ git clean -fn
Would remove untracked_file
next prev parent reply other threads:[~2013-01-10 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 23:16 [PATCH v4] git-clean: Display more accurate delete messages Zoltan Klinger
2013-01-06 23:40 ` Jonathan Nieder
2013-01-10 1:01 ` Zoltan Klinger
2013-01-10 2:56 ` Junio C Hamano
2013-01-10 10:41 ` Zoltan Klinger [this message]
2013-01-10 17:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKJhZwQ=RzLgCBUrx_QKY8Xzh-L8QC2UVcQJEpYxxGQz=8LwwQ@mail.gmail.com' \
--to=zoltan.klinger@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).