From: "Gaël Lhez" <gael.lhez@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: gitgitgadget@gmail.com, git@vger.kernel.org,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] bundle: refuse to create empty bundle
Date: Tue, 13 Nov 2018 21:37:18 +0100 [thread overview]
Message-ID: <CAK8L4uhL4Z7nsZKha59vePHiPR6FtRgbp6WjB8eL8WOcsZRDnQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kYR_mQmtOuW7SEZ92K_o0f_C2enJJ1Yt=V3tyvi-A53+A@mail.gmail.com>
Hello,
I don't know why I receive these message (and especially now given the
time at which I pushed this) but I suppose someone (Johannes
Schindelin ?) probably pushed back my original commit from git for
windows github to GIT git repository.
If you think "bundle: cleanup lock files on error" is better, then no
problem with me. I'm not a native english speaker and I simply
expressed the reason for my problem but - after reading back my commit
- neither this mail' subject and my original commit subject (see
https://github.com/git-for-windows/git/pull/797/commits/0ef742a1a92ae53188189238adbd16086fabf80a)
express the core problem.
As I'm not accustomed to pushing on GIT 'git repository' , please let
me know if I have something else to do ?
(Sent back in text mode because HTML is considered SPAM or Virus by
git@vger.kernel.org).
Regards,
Gaël
Le mar. 13 nov. 2018 à 20:28, Stefan Beller <sbeller@google.com> a écrit :
>
> On Tue, Nov 13, 2018 at 7:09 AM Gaël Lhez via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > From: =?UTF-8?q?Ga=C3=ABl=20Lhez?= <gael.lhez@gmail.com>
> >
> > When an user tries to create an empty bundle via `git bundle create
> > <bundle> <revlist>` where `<revlist>` resolves to an empty list (for
> > example, like `master..master`), the command fails and warns the user
> > about how it does not want to create empty bundle.
> >
> > However, the `.lock` file was still open and on Windows that means
> > that it could not be deleted properly. This patch fixes that issue.
> >
> > This closes https://github.com/git-for-windows/git/issues/790
> >
> > Signed-off-by: Gaël Lhez <gael.lhez@gmail.com>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The code and the commit message make sense, but by reading the subject line
>
> I would have expected a different commit. Maybe
> "bundle: cleanup lock files on error"
next prev parent reply other threads:[~2018-11-13 20:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 15:09 [PATCH 0/1] bundle: fix issue when bundles would be empty Johannes Schindelin via GitGitGadget
2018-11-13 15:09 ` [PATCH 1/1] bundle: refuse to create empty bundle Gaël Lhez via GitGitGadget
2018-11-13 19:28 ` Stefan Beller
2018-11-13 20:37 ` Gaël Lhez [this message]
[not found] ` <CAK8L4uiMHrsdwJz9+rD1tSCywL2kHosx-hKZdS=UtZDHLy464A@mail.gmail.com>
2018-11-13 21:11 ` Stefan Beller
2018-11-14 15:23 ` Johannes Schindelin
2018-11-14 15:25 ` [PATCH v2 0/1] bundle: fix issue when bundles would be empty Johannes Schindelin via GitGitGadget
2018-11-14 15:25 ` [PATCH v2 1/1] bundle: cleanup lock files on error Gaël Lhez via GitGitGadget
2018-11-14 21:43 ` Martin Ågren
2018-11-14 22:08 ` Stefan Beller
2018-11-15 4:34 ` Jeff King
2018-11-15 12:57 ` Johannes Schindelin
2018-11-15 13:37 ` Jeff King
2018-11-15 16:32 ` Johannes Schindelin
2018-11-15 16:43 ` Jeff King
2018-11-15 20:01 ` Johannes Schindelin
2018-11-16 9:43 ` [PATCH] bundle: dup() output descriptor closer to point-of-use Jeff King
2018-11-16 15:06 ` Johannes Schindelin
2018-11-17 7:05 ` Junio C Hamano
2018-11-15 16:49 ` [PATCH v2 1/1] bundle: cleanup lock files on error Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8L4uhL4Z7nsZKha59vePHiPR6FtRgbp6WjB8eL8WOcsZRDnQ@mail.gmail.com \
--to=gael.lhez@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).