From: Marius Paliga <marius.paliga@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Enhancement request: git-push: Allow (configurable) default push-option
Date: Wed, 4 Oct 2017 17:20:10 +0200 [thread overview]
Message-ID: <CAK7vU=3whGsx4L4KACSC+XDWQEbUWuZZZqTsW2R=CbF8d7rkuQ@mail.gmail.com> (raw)
In-Reply-To: <CAGZ79kaBJnXW=rSiKuHpds79mXVL0Aoo+PBa0a5V-C_bop=Kbg@mail.gmail.com>
Hi Stefan,
I will look at it.
Thanks,
Marius
2017-10-03 18:53 GMT+02:00 Stefan Beller <sbeller@google.com>:
> On Tue, Oct 3, 2017 at 3:15 AM, Marius Paliga <marius.paliga@gmail.com> wrote:
>> There is a need to pass predefined push-option during "git push"
>> without need to specify it explicitly.
>>
>> In another words we need to have a new "git config" variable to
>> specify string that will be automatically passed as "--push-option"
>> when pushing to remote.
>>
>> Something like the following:
>>
>> git config push.optionDefault AllowMultipleCommits
>>
>> and then command
>> git push
>> would silently run
>> git push --push-option "AllowMultipleCommits"
>
> We would need to
> * design this feature (seems like you already have a good idea what you need)
> * implement it (see builtin/push.c):
> - move "struct string_list push_options = STRING_LIST_INIT_DUP;"
> to be a file-static variable, such that we have access to it outside
> of cmd_push.
> - In git_push_config in builtin/push.c that parses the config, we'd
> need to check
> for "push.optionDefault" and add these to the push_options (I assume multiple
> are allowed)
> * document it (Documentation/git-push.txt)
> * add a test for it ? (t/t5545-push-options.sh)
>
> Care to write a patch? Otherwise I'd mark it up as part of
> #leftoverbits for now,
> as it seems like a good starter project.
>
> Thanks,
> Stefan
next prev parent reply other threads:[~2017-10-04 15:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 10:15 Enhancement request: git-push: Allow (configurable) default push-option Marius Paliga
2017-10-03 16:53 ` Stefan Beller
2017-10-04 15:20 ` Marius Paliga [this message]
2017-10-11 7:14 ` Marius Paliga
2017-10-11 9:18 ` Marius Paliga
2017-10-11 20:52 ` Stefan Beller
2017-10-11 11:13 ` Junio C Hamano
2017-10-11 13:38 ` Junio C Hamano
2017-10-12 14:59 ` Marius Paliga
2017-10-12 16:32 ` Marius Paliga
2017-10-12 16:51 ` Stefan Beller
2017-10-13 1:39 ` Junio C Hamano
2017-10-13 0:37 ` Junio C Hamano
2017-10-13 8:45 ` Marius Paliga
2017-10-11 20:25 ` Thais D. Braz
2017-10-11 20:25 ` [PATCH][Outreachy] New git config variable to specify string that will be automatically passed as --push-option Thais D. Braz
2017-10-12 1:21 ` Junio C Hamano
2017-10-12 2:41 ` Christian Couder
2017-10-12 3:26 ` Junio C Hamano
2017-10-17 3:47 ` [PATCH] patch reply Thais Diniz
2017-10-17 4:01 ` Junio C Hamano
2017-10-17 7:15 ` Marius Paliga
2017-10-17 3:58 ` [PATCH][Outreachy] New git config variable to specify string that will be automatically passed as --push-option thais braz
2017-10-11 20:40 ` Thais D. Braz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7vU=3whGsx4L4KACSC+XDWQEbUWuZZZqTsW2R=CbF8d7rkuQ@mail.gmail.com' \
--to=marius.paliga@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).