From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [GSoC] [PATCH 1/1] t0001: replace "test [-d|-f]" with test_path_is_* functions
Date: Fri, 11 Feb 2022 17:56:21 +0800 [thread overview]
Message-ID: <CAJyCBOR7KbRxuXJUJ2TrffAjj=rwB3H-Ys9tVUuWGjUKf_LHsw@mail.gmail.com> (raw)
In-Reply-To: <xmqqv8xmvdoa.fsf@gitster.g>
Hi Junio,
On Fri, Feb 11, 2022 at 1:23 AM Junio C Hamano <gitster@pobox.com> wrote:
> FWIW, I have the posted patch plus the following SQUASH??? fix-up
I'm not so sure what does "SQUASH???" mean especially the three
question marks, i.e. is it just an incidental text or a commit message
convention?
Is it for the convenience of grepping through the
"git log" outputs (cause I found the commit 50d631c71c right away by
grepping through the "git log" output)?
> parked in the 'seen' branch. As the script is quiescent right now,
> I do not mind merging it down, now we spent more time on it ;-)
>
> t/t0001-init.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index c72a28d3a5..d479303efa 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -6,7 +6,8 @@ TEST_PASSES_SANITIZE_LEAK=true
> . ./test-lib.sh
>
> check_config () {
> - if test_path_is_dir "$1" && test_path_is_file "$1/config" && test_path_is_dir "$1/refs"
> + if test_path_is_dir "$1" &&
> + test_path_is_file "$1/config" && test_path_is_dir "$1/refs"
> then
> : happy
> else
Yeah, I think wrapping it around is a good idea :-)
> --
> 2.35.1-102-g2b9c120970
>
--
Thanks & Regards,
Shaoxuan
next prev parent reply other threads:[~2022-02-11 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 10:21 [GSoC] [PATCH 0/1] t0001: replace "test [-d|-f]" with test_path_is_* functions Shaoxuan Yuan
2022-01-21 10:21 ` [GSoC] [PATCH 1/1] " Shaoxuan Yuan
2022-01-21 18:46 ` Taylor Blau
2022-01-21 20:49 ` Junio C Hamano
2022-01-24 5:56 ` Shaoxuan Yuan
2022-02-10 3:11 ` Shaoxuan Yuan
2022-02-10 7:12 ` Junio C Hamano
2022-02-10 7:21 ` Shaoxuan Yuan
2022-02-10 17:23 ` Junio C Hamano
2022-02-11 9:56 ` Shaoxuan Yuan [this message]
2022-02-11 16:53 ` Junio C Hamano
2022-02-14 8:45 ` Christian Couder
2022-02-14 8:53 ` Shaoxuan Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJyCBOR7KbRxuXJUJ2TrffAjj=rwB3H-Ys9tVUuWGjUKf_LHsw@mail.gmail.com' \
--to=shaoxuan.yuan02@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).