From: Shaoxuan Yuan <shaoxuan.yuan02@gmail.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 2/2] t/lib-read-tree-m-3way: indent with tabs
Date: Tue, 8 Feb 2022 09:47:12 +0800 [thread overview]
Message-ID: <CAJyCBOQR5wWkQhcVBVC7xJQDsaciifmX5LVuwPhBX2sVLMB7bw@mail.gmail.com> (raw)
In-Reply-To: <CAP8UFD0c=TeBwcyWo_GKLKV7Y8837beHLk7JGqfF9_DU79NWig@mail.gmail.com>
On Mon, Feb 7, 2022 at 7:54 PM Christian Couder
<christian.couder@gmail.com> wrote:
>
> On Sun, Feb 6, 2022 at 10:51 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail.com> wrote:
> >
> > As Documentation/CodingGuidelines says, our shell scripts
> > (including tests) are to use HT for indentation, but this script
>
> Documentation/CodingGuidelines talks about "tabs" for indentation not
> "HT", so it would be more consistent to talk about "tabs" here too, or
> at least to say something like "are to use HT (horizontal tab) for
> indentation".
Agree, it should be phrased in a more consistent and understandable way.
> > uses 4-column indent with SP. Fix this.
>
> Same for "SP" here vs "space" in our doc. (Also note that `man ascii`
> talks about "HT" and "SPACE", not "SP".)
Agree.
--
Thanks,
Shaoxuan
next prev parent reply other threads:[~2022-02-08 1:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 6:03 [GSoC][PATCH] lib-read-tree-m-3way: modernize a test script (style) Shaoxuan Yuan
2022-01-27 10:54 ` Shaoxuan Yuan
2022-01-28 8:34 ` Eric Sunshine
2022-01-28 9:51 ` Shaoxuan Yuan
2022-02-05 11:59 ` Eric Sunshine
2022-02-07 13:10 ` Shaoxuan Yuan
2022-01-30 9:43 ` [PATCH v2 0/2] t/lib-read-tree-m-3way: modernize a test script Shaoxuan Yuan
2022-01-30 9:43 ` [PATCH v2 1/2] t/lib-read-tree-m-3way: replace double quotes with single quotes Shaoxuan Yuan
2022-02-01 23:51 ` Junio C Hamano
2022-02-02 4:52 ` Shaoxuan Yuan
2022-01-30 9:43 ` [PATCH v2 2/2] t/lib-read-tree-m-3way: replace spaces with tabs Shaoxuan Yuan
2022-02-01 23:57 ` Junio C Hamano
2022-02-02 4:59 ` Shaoxuan Yuan
2022-02-02 6:42 ` [PATCH v3 1/2] t/lib-read-tree-m-3way: modernize style Shaoxuan Yuan
2022-02-02 6:43 ` [PATCH v3 2/2] t/lib-read-tree-m-3way: indent with tabs Shaoxuan Yuan
2022-02-07 11:54 ` Christian Couder
2022-02-08 1:47 ` Shaoxuan Yuan [this message]
2022-02-07 11:41 ` [PATCH v3 1/2] t/lib-read-tree-m-3way: modernize style Christian Couder
2022-02-08 1:43 ` Shaoxuan Yuan
2022-02-08 3:24 ` [PATCH v4 0/2] t/lib-read-tree-m-3way: modernize a test script Shaoxuan Yuan
2022-02-08 3:24 ` [PATCH v4 1/2] t/lib-read-tree-m-3way: modernize style Shaoxuan Yuan
2022-02-08 3:24 ` [PATCH v4 2/2] t/lib-read-tree-m-3way: indent with tabs Shaoxuan Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJyCBOQR5wWkQhcVBVC7xJQDsaciifmX5LVuwPhBX2sVLMB7bw@mail.gmail.com \
--to=shaoxuan.yuan02@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).