From: Shawn Pearce <spearce@spearce.org>
To: Parker Moore <parkrmoore@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
git <git@vger.kernel.org>, Colby Ranger <cranger@google.com>
Subject: Re: [PATCH] contrib/persistent-https: update ldflags syntax for Go 1.7+
Date: Mon, 18 Jul 2016 21:49:15 -0700 [thread overview]
Message-ID: <CAJo=hJviMd3tWe_HUmh0M0Y2TOCwwrZX14hdyivPSYQ1ck052w@mail.gmail.com> (raw)
In-Reply-To: <CAOiOGAfysmjBxcK-VwscLWBdun4rNsRs85p=foBxETvQw0J1Jw@mail.gmail.com>
On Mon, Jul 18, 2016 at 9:32 PM, Parker Moore <parkrmoore@gmail.com> wrote:
>> The label does not even identify the version of the source in any way, so I am not sure how people are depending on that feature anyway ;-)
>
> Would it be a better solution simply to remove this build flag?
> Alternatively, if Git wished to support Go v1.5 and below, I would be
> more than happy to send a patch with a dynamic lookup in the Makefile
> based on the output of `go version`. I would be more than happy to
> submit either patch.
I think we could remove that BUILD_LABEL entirely. Colby liked having
a marker so he knows what "version" a user is running, but without any
correlation to source here it just isn't that useful.
next prev parent reply other threads:[~2016-07-19 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 20:44 [PATCH] contrib/persistent-https: update ldflags syntax for Go 1.7+ Parker Moore
2016-07-16 5:18 ` Jeff King
2016-07-18 20:36 ` Junio C Hamano
2016-07-19 4:32 ` Parker Moore
2016-07-19 4:49 ` Shawn Pearce [this message]
2016-07-19 17:04 ` Junio C Hamano
2016-07-19 23:32 ` Parker Moore
2016-07-20 19:21 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2016-07-21 0:58 Parker Moore
2016-07-22 17:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJo=hJviMd3tWe_HUmh0M0Y2TOCwwrZX14hdyivPSYQ1ck052w@mail.gmail.com' \
--to=spearce@spearce.org \
--cc=cranger@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=parkrmoore@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).