From: Dominique Quatravaux <domq@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Barr <davidbarr@google.com>,
git@vger.kernel.org, Thomas Rast <trast@inf.ethz.ch>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [PATCHv2 1/2] rebase -i: optimize the creation of the todo file
Date: Fri, 9 Mar 2012 10:52:03 +0100 [thread overview]
Message-ID: <CAJh6GrH3x-Fz5gqKdu_fcmH0OH3KG8En3H2vURKhkYuiC+s59g@mail.gmail.com> (raw)
In-Reply-To: <7vpqcm85rs.fsf@alter.siamese.dyndns.org>
On Fri, Mar 9, 2012 at 10:47 AM, Junio C Hamano <gitster@pobox.com> wrote:
> David Barr <davidbarr@google.com> writes:
>
>> I do notice however that the output being fed to sed expands like so:
>>
>> commit >634a5f265ad729b91266de65272e2b5a35d05b1c
>> >634a5f265ad729b91266de65272e2b5a35d05b1c 634a5f2 INSTALL: warn [...]
>> commit >828ea97de486c1693d6e4f2c7347acb50235a85d
>> >828ea97de486c1693d6e4f2c7347acb50235a85d 828ea97 Git 1.7.9
>>
>> Maybe the format spec and sed command could use a little tuning.
>
> Why would that be a problem, though? The sed script picks only
> lines that begin with '>' and discards the traditional diff-tree
> style per commit header, no?
I assume that David wants to have
commit >634a5f265ad729b91266de65272e2b5a35d05b1c
634a5f2 INSTALL: warn [...]
and chew on that with sed.
--
Dominique Quatravaux
+41 79 609 40 72
prev parent reply other threads:[~2012-03-09 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 13:52 [PATCHv2 1/2] rebase -i: optimize the creation of the todo file Dominique Quatravaux
2012-03-08 13:52 ` [PATCHv2 2/2] rebase -i: new option --name-rev Dominique Quatravaux
2012-03-09 5:00 ` [PATCHv2 1/2] rebase -i: optimize the creation of the todo file David Barr
2012-03-09 9:18 ` Dominique Quatravaux
2012-03-09 9:21 ` Dominique Quatravaux
2012-03-09 9:47 ` Junio C Hamano
2012-03-09 9:52 ` Dominique Quatravaux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJh6GrH3x-Fz5gqKdu_fcmH0OH3KG8En3H2vURKhkYuiC+s59g@mail.gmail.com \
--to=domq@google.com \
--cc=davidbarr@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).