From: John Passaro <john.a.passaro@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] run-command: report exec failure
Date: Wed, 12 Dec 2018 10:27:40 -0500 [thread overview]
Message-ID: <CAJdN7Khf+Y_jyyG2qoqiMHYPCHHSws15EDftOQni=gFJ7SoMXg@mail.gmail.com> (raw)
In-Reply-To: <xmqqsgz4jkgl.fsf@gitster-ct.c.googlers.com>
Thank you for this incredibly quick fix.
I see the fix made it to pu as 6b206be3e5 ("run-command: report exec
failure" 2018-12-11). For what it's worth, it fixes the issue as far
as I'm concerned and I'm very glad to see the behavior is covered by
tests now.
As a procedural question: I'd like to reference this patch in one of
my own. Can I reference it as I typed it above? Or is there a chance
of the SHA1 changing before it goes into some sort of a main history?
John Passaro
(917) 678-8293
On Tue, Dec 11, 2018 at 7:50 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > This breaks on Windows (on Windows, the error message says "cannot spawn", see
>
> Thanks for a quick feedback. Let's update to look for the pathname
> of the command, as Peff suggested earlier.
next prev parent reply other threads:[~2018-12-12 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 5:46 [PATCH] run-command: report exec failure Junio C Hamano
2018-12-11 10:23 ` Jeff King
2018-12-11 12:31 ` Johannes Schindelin
2018-12-11 12:50 ` Junio C Hamano
2018-12-12 15:27 ` John Passaro [this message]
2018-12-13 8:10 ` Jeff King
2018-12-12 18:36 ` [PATCH v2] " Junio C Hamano
2018-12-13 8:08 ` Jeff King
2018-12-13 8:17 ` Junio C Hamano
2018-12-13 11:15 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJdN7Khf+Y_jyyG2qoqiMHYPCHHSws15EDftOQni=gFJ7SoMXg@mail.gmail.com' \
--to=john.a.passaro@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).