From: David Aguilar <davvid@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v2 try2 0/4] completion: bash: a bunch of fixes
Date: Sun, 6 Jun 2021 17:46:06 -0700 [thread overview]
Message-ID: <CAJDDKr4Wm2FQ-kq8k8EU6wE20V6ghuKDrzC5PcsZ6We0bMz3uQ@mail.gmail.com> (raw)
In-Reply-To: <20210606184726.1018460-1-felipe.contreras@gmail.com>
On Sun, Jun 6, 2021 at 11:51 AM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
>
> These should be pretty obvious and straightforward.
>
> This is the second time I'm sending this exact series, and the seventh time in almost
> exactly the same form.
>
> The previous version was still applying without conflicts to master, and so does this one.
>
> * https://lore.kernel.org/git/xmqqv9cavcc5.fsf@gitster.c.googlers.com/
> * https://lore.kernel.org/git/6094a335c22dc_8ee520860@natae.notmuch/
>
> Felipe Contreras (4):
> completion: bash: fix prefix detection in branch.*
> completion: bash: fix for suboptions with value
> completion: bash: fix for multiple dash commands
> completion: bash: add correct suffix in variables
>
> contrib/completion/git-completion.bash | 14 +++++++-------
> t/t9902-completion.sh | 15 +++++++++++++++
> 2 files changed, 22 insertions(+), 7 deletions(-)
>
> Range-diff:
> 1: dd49b0e680 ! 1: 52de92cb06 completion: bash: fix prefix detection in branch.*
> @@ Commit message
>
> git clone --config=branch.<tab>
>
> + Reviewed-by: SZEDER Gábor <szeder.dev@gmail.com>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> ## contrib/completion/git-completion.bash ##
> 2: 6ac184b9a4 = 2: af2f17364d completion: bash: fix for suboptions with value
> 3: 960a692fda = 3: a3bcb70594 completion: bash: fix for multiple dash commands
> 4: a95c3edaf9 = 4: 6b3ef41c92 completion: bash: add correct suffix in variables
> --
> 2.31.1.2.g0532ba4bf6
>
I tested this series on:
- GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
- GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)
- zsh 5.0.2 (x86_64-redhat-linux-gnu)
- zsh 5.7.1 (x86_64-apple-darwin19.0)
and can confirm that it is an improvement.
FWIW,
Tested-by: David Aguilar <davvid@gmail.com>
cheers,
--
David
next prev parent reply other threads:[~2021-06-07 0:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 18:47 [PATCH v2 try2 0/4] completion: bash: a bunch of fixes Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-07 19:00 ` SZEDER Gábor
2021-06-07 19:11 ` Felipe Contreras
2021-06-08 5:15 ` Junio C Hamano
2021-06-08 5:49 ` Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 4/4] completion: bash: add correct suffix in variables Felipe Contreras
2021-06-07 0:46 ` David Aguilar [this message]
2021-06-07 1:08 ` [PATCH v2 try2 0/4] completion: bash: a bunch of fixes Junio C Hamano
2021-06-08 6:00 ` [PATCH v3 " Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-08 6:00 ` [PATCH v3 4/4] completion: bash: add correct suffix in variables Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDDKr4Wm2FQ-kq8k8EU6wE20V6ghuKDrzC5PcsZ6We0bMz3uQ@mail.gmail.com \
--to=davvid@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).