From: Brian Malehorn <bmalehorn@gmail.com>
To: git@vger.kernel.org
Subject: git stash --include-untracked walks ignored directories
Date: Tue, 9 Jun 2020 12:33:00 -0700 [thread overview]
Message-ID: <CAJB88a39G-GkGu1LuRE8na45Pav_cWb3cJLQFJM+FuW3BnromA@mail.gmail.com> (raw)
Hi,
Not sure if this is the right place to send this, but I'm here to
report a performance regression with git stash --include-untracked.
Here's a quick way to reproduce:
1. make a directory with a lot of ignored files
$ find ignored -type f | wc -l
50000
$ cat .gitignore
ignored
2. touch foo
3. time git stash --include-untracked
git version 2.26.0:
real 0m0.094s
git version 2.27.0.83.g0313f36c6e:
real 0m1.913s
This is a much bigger pain point on my work repo, which has 1.4
million ignored files(!). As you can imagine it takes a long time to
run git stash. While it might be valid to question why anyone would
need that many files for any purpose, the bottom line is that I told
git to ignore this directory, and it didn't ignore it.
In the meantime I've reverted to 2.26.0 which doesn't have this
performance regression. Let me know if you want any other information
related to this issue.
Thanks,
Brian
next reply other threads:[~2020-06-09 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 19:33 Brian Malehorn [this message]
2020-06-10 3:21 ` git stash --include-untracked walks ignored directories Elijah Newren
2020-06-10 5:56 ` Brian Malehorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJB88a39G-GkGu1LuRE8na45Pav_cWb3cJLQFJM+FuW3BnromA@mail.gmail.com \
--to=bmalehorn@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).