From: Luis Marsano <luis.marsano@gmail.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org, "Ted Zlatanov" <tzz@lifelogs.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [RFC PATCH v2 0/4] contrib/credential/netrc Makefile & test improvements
Date: Wed, 13 Jun 2018 02:59:17 -0400 [thread overview]
Message-ID: <CAHqJXRHZSGQF9cR8f4N5j8oSRCAoNzXnWLAsGO4witjmHU63ZA@mail.gmail.com> (raw)
In-Reply-To: <20180613031040.3109-1-tmz@pobox.com>
On Tue, Jun 12, 2018 at 11:10 PM Todd Zullinger <tmz@pobox.com> wrote:
>
> This replaces my 2/2 "use in-tree Git.pm for tests" with
> Luis's improved version. It also adds Luis's fix to ensure
> the proper exit status on test failures and a minor
> whitespace cleanup.
>
> Is it alright to forge your signoff Luis?
Thanks, that's fine.
You should sign-off on those, too: you identified the problems, told
me the solutions, tested them, and deserve the credit.
Moreover, Documentation/SubmittingPatches encourages it.
When the patches are ready, I think we'll need the primary author
(Ted) to acknowledge before the maintainer (Junio) can approve.
> Luis Marsano (2):
> git-credential-netrc: use in-tree Git.pm for tests
> git-credential-netrc: fix exit status when tests fail
>
> Todd Zullinger (2):
> git-credential-netrc: make "all" default target of Makefile
> git-credential-netrc: minor whitespace cleanup in test script
>
> contrib/credential/netrc/Makefile | 3 +++
> contrib/credential/netrc/t-git-credential-netrc.sh | 9 +++++----
> contrib/credential/netrc/test.pl | 5 +++--
> 3 files changed, 11 insertions(+), 6 deletions(-)
next prev parent reply other threads:[~2018-06-13 6:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 5:19 [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements Todd Zullinger
2018-06-07 5:19 ` [RFC PATCH 1/2] git-credential-netrc: make "all" default target of Makefile Todd Zullinger
2018-06-07 5:19 ` [RFC PATCH 2/2] git-credential-netrc: use in-tree Git.pm for tests Todd Zullinger
2018-06-09 21:18 ` [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements Luis Marsano
2018-06-10 2:28 ` Todd Zullinger
2018-06-10 8:36 ` Ævar Arnfjörð Bjarmason
2018-06-13 3:08 ` Todd Zullinger
2018-06-13 6:15 ` Luis Marsano
2018-06-13 7:48 ` [PATCH] git-credential-netrc: remove use of "autodie" Ævar Arnfjörð Bjarmason
2018-06-13 16:48 ` Junio C Hamano
2018-06-13 17:26 ` Todd Zullinger
2018-06-13 3:10 ` [RFC PATCH v2 0/4] contrib/credential/netrc Makefile & test improvements Todd Zullinger
2018-06-13 6:59 ` Luis Marsano [this message]
2018-06-13 3:10 ` [RFC PATCH v2 1/4] git-credential-netrc: make "all" default target of Makefile Todd Zullinger
2018-06-13 3:10 ` [RFC PATCH v2 2/4] git-credential-netrc: minor whitespace cleanup in test script Todd Zullinger
2018-06-13 5:42 ` Eric Sunshine
2018-06-13 17:21 ` Todd Zullinger
2018-06-13 17:43 ` Eric Sunshine
2018-06-13 3:10 ` [RFC PATCH v2 3/4] git-credential-netrc: use in-tree Git.pm for tests Todd Zullinger
2018-06-13 3:10 ` [RFC PATCH v2 4/4] git-credential-netrc: fix exit status when tests fail Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHqJXRHZSGQF9cR8f4N5j8oSRCAoNzXnWLAsGO4witjmHU63ZA@mail.gmail.com \
--to=luis.marsano@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=tmz@pobox.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).