From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff King <peff@peff.net>
Cc: "Git List Mailing" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>
Subject: Re: [PATCH 1/2] commit-graph: don't show progress percentages while expanding reachable commits
Date: Fri, 27 Sep 2019 11:54:11 -0700 [thread overview]
Message-ID: <CAHk-=wjk5c=zKVb_EbB5FWyNGD6d3GW8ayB3=2Boo83uq7JBiA@mail.gmail.com> (raw)
In-Reply-To: <20190907050132.GA23904@sigill.intra.peff.net>
I was going to make a bug-report about this funny behavior, but
decided to search the list first.
Yeah, I smiled at
Expanding reachable commits in commit graph: 139276% (870481/625), done.
when I did the "git gc --prune=now" on the kernel, and apparently
actually looked at the noise for the first time in a while.
So I don't mind the bug, but I think this should be fixed. Because
almost 140 _thousand_ percent just isn't right.
So Ack on this patch. Looks like it is already in 'pu', but hasn't
made it into next or master yet.
Linus
On Fri, Sep 6, 2019 at 10:04 PM Jeff King <peff@peff.net> wrote:
>
> From: SZEDER Gábor <szeder.dev@gmail.com>
>
> Commit 49bbc57a57 (commit-graph write: emit a percentage for all
> progress, 2019-01-19) was a bit overeager when it added progress
> percentages/ [...]
next prev parent reply other threads:[~2019-09-27 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 4:58 [PATCH 0/2] a few commit-graph improvements Jeff King
2019-09-07 5:01 ` [PATCH 1/2] commit-graph: don't show progress percentages while expanding reachable commits Jeff King
2019-09-07 10:34 ` SZEDER Gábor
2019-09-07 18:54 ` Taylor Blau
2019-09-27 18:54 ` Linus Torvalds [this message]
2019-09-07 5:04 ` [PATCH 2/2] commit-graph: turn off save_commit_buffer Jeff King
2019-09-07 18:56 ` Taylor Blau
2019-09-08 10:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjk5c=zKVb_EbB5FWyNGD6d3GW8ayB3=2Boo83uq7JBiA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).