From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 332CF1F5AE for ; Thu, 18 Jun 2020 20:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729282AbgFRU3l (ORCPT ); Thu, 18 Jun 2020 16:29:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbgFRU3l (ORCPT ); Thu, 18 Jun 2020 16:29:41 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A0BC06174E for ; Thu, 18 Jun 2020 13:29:40 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id i3so8901809ljg.3 for ; Thu, 18 Jun 2020 13:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FNFdJLmIZbV7r218zDApYm8VS3sbW9DPdrSNfobd598=; b=dnsR2sovtNlKdiBT15l0yiI7DzgE65iss/NBHKv9553RzwclfaxZV8rt/y7VkRT8ei 4iGzkV+8Vj64xE8lZsyD/5ukX6mIbzZ5BLO8lQsoGh9IRU5Z/crZyUGr5ooI4YH89ZNs gDsuinhZE0MDLehZjNa86c9W80PGIl7YIcmDymxwH0xkg/d2RHzvprp6FH23SzNWpgmZ Fhli9j57so99nmBiVOJGyI25KREE8XylbLAEf21g1mDy55UrSsilJFSU6RZBz6AFQCxq EzDUajgXiuhXUtI9CA0+BKGaDs0ScZNqrz5lMQ+d4tMK3OBvzyGfae165WJEySpuK1vK u61g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FNFdJLmIZbV7r218zDApYm8VS3sbW9DPdrSNfobd598=; b=qr2EL0nPQqF3z3w85/h/IzyawDEKhVfX0WEIfN9e7doV3ZVazbdVpHsZH7wpySfc2E QtWtb1OTmIrmLa3pTbcKEd/v7mNTODfQMNBsCb1ylmb1biGAqar3iKvAXiRLMcBashzX ipN9RmkY38lmX4XLBfeolWqro/vjwr7RVLIc4AEqf3C/3XejwwZEEVfjUccHu3ZKAp0W JmPoVmKdgfJrsFd0a53uChBCpXkesnS7Pk2Hcv5RW/UgWdank4gMZwU01IT5VS1oX5Cz eWTxutvUR0PNOH4WVotsCPZQgxLVqS405AWPhij4U6LIURpw1kDl77paEo+JJRrow60I 0hzg== X-Gm-Message-State: AOAM533sJtYIcXiwlO1nzSUjnclQVYtyaU77rtdt8uAgIRP0YIkky3dX GDXGDZdWR/mcXb1KcoMImE8rQLR39gr1i3DHOD/DRA== X-Google-Smtp-Source: ABdhPJztq2ytgUt2Gt8U3FKWRaJ1xD3DA56v+AzEwZ+n/Y3TfznqvdWCr6C/cdNB/yPXoIH6UeMe3pndRLWPlw6Chlw= X-Received: by 2002:a2e:1558:: with SMTP id 24mr86515ljv.202.1592512179389; Thu, 18 Jun 2020 13:29:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Matheus Tavares Bernardino Date: Thu, 18 Jun 2020 17:29:28 -0300 Message-ID: Subject: Re: [PATCH] unpack-trees: do not set SKIP_WORKTREE on submodules To: Elijah Newren Cc: Elijah Newren via GitGitGadget , git , Derrick Stolee Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jun 18, 2020 at 4:20 PM Elijah Newren wrote: > > On Thu, Jun 18, 2020 at 7:34 AM Matheus Tavares Bernardino > wrote: > > > > On Wed, Jun 17, 2020 at 9:24 PM Elijah Newren wrote: > > > > > > When we notice an initialized submodule that does not match the > > > sparsity patterns, we should print a warning just like we do for > > > unmerged and dirty entries. > > > > Yeah, seems like a good approach. Thanks for the explanations. Some of > > the test cases in mt/grep-sparse-checkout will have to be adjusted > > with this change. Should I reroll the series based on the patch you > > will send or do you prefer to adjust them in your patch (and make it > > dependent on mt/grep-sparse-checkout)? > > Ah, good catch. Your series came first, is longer, and is reviewed > other than the submodule/config stuff that needs someone more familiar > with that area than me. Since my patch needs more work anyway, how > about I rebase my patch on top of your work, and make sure to ping you > as a reviewer to make sure I don't mess anything up? Sounds good :) Thanks