From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Elijah Newren <newren@gmail.com>
Cc: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
git <git@vger.kernel.org>, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH] unpack-trees: do not set SKIP_WORKTREE on submodules
Date: Thu, 18 Jun 2020 17:29:28 -0300 [thread overview]
Message-ID: <CAHd-oW7S1NKtwy=LdV95Nw-FPbLyUDV34BXLzd1D7Y6g29AtbQ@mail.gmail.com> (raw)
In-Reply-To: <CABPp-BHV6iKH4PS6Gqfhe6piBdgmZ9D+cgXvSJ+dNcw-UHD-+w@mail.gmail.com>
On Thu, Jun 18, 2020 at 4:20 PM Elijah Newren <newren@gmail.com> wrote:
>
> On Thu, Jun 18, 2020 at 7:34 AM Matheus Tavares Bernardino
> <matheus.bernardino@usp.br> wrote:
> >
> > On Wed, Jun 17, 2020 at 9:24 PM Elijah Newren <newren@gmail.com> wrote:
> > >
> > > When we notice an initialized submodule that does not match the
> > > sparsity patterns, we should print a warning just like we do for
> > > unmerged and dirty entries.
> >
> > Yeah, seems like a good approach. Thanks for the explanations. Some of
> > the test cases in mt/grep-sparse-checkout will have to be adjusted
> > with this change. Should I reroll the series based on the patch you
> > will send or do you prefer to adjust them in your patch (and make it
> > dependent on mt/grep-sparse-checkout)?
>
> Ah, good catch. Your series came first, is longer, and is reviewed
> other than the submodule/config stuff that needs someone more familiar
> with that area than me. Since my patch needs more work anyway, how
> about I rebase my patch on top of your work, and make sure to ping you
> as a reviewer to make sure I don't mess anything up?
Sounds good :) Thanks
next prev parent reply other threads:[~2020-06-18 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 1:21 [PATCH] unpack-trees: do not set SKIP_WORKTREE on submodules Elijah Newren via GitGitGadget
2020-06-17 17:58 ` Matheus Tavares Bernardino
2020-06-18 0:24 ` Elijah Newren
2020-06-18 14:34 ` Matheus Tavares Bernardino
2020-06-18 19:19 ` Elijah Newren
2020-06-18 20:29 ` Matheus Tavares Bernardino [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-18 1:51 How soon
2020-10-06 0:06 Luv MeZza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHd-oW7S1NKtwy=LdV95Nw-FPbLyUDV34BXLzd1D7Y6g29AtbQ@mail.gmail.com' \
--to=matheus.bernardino@usp.br \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).