From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Elijah Newren <newren@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git.git (Aug 2020, #07; Thu, 27)
Date: Sat, 29 Aug 2020 01:28:02 -0300 [thread overview]
Message-ID: <CAHd-oW75wy07jo+pZzqjkzYekMWVSp0DmEVNQLG8GyTPNLZ1bQ@mail.gmail.com> (raw)
In-Reply-To: <CABPp-BHCVWWFDL2kpWymNuX_t4anX2Xw-xiTK8N+MdrBoopERg@mail.gmail.com>
Hi, Elijah
On Thu, Aug 27, 2020 at 11:16 PM Elijah Newren <newren@gmail.com> wrote:
>
> On Thu, Aug 27, 2020 at 2:46 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > * mt/grep-sparse-checkout (2020-06-12) 6 commits
> > - config: add setting to ignore sparsity patterns in some cmds
> > - grep: honor sparse checkout patterns
> > - config: correctly read worktree configs in submodules
> > - t/helper/test-config: facilitate addition of new cli options
> > - t/helper/test-config: return exit codes consistently
> > - doc: grep: unify info on configuration variables
> >
> > "git grep" has been tweaked to be limited to the sparse checkout
> > paths.
> >
> > Review needed on 4/6; otherwise looking sane.
> > cf. <CABPp-BGdEyEeajYZj_rdxp=MyEQdszuyjVTax=hhYj3fOtRQUQ@mail.gmail.com>
>
> Kinda disappointed to see this stalled out; especially after so much
> work put into it. This spawned lots of other side discussions and a
> topic or two outside this series as well. I really like the overall
> result we came up with out of this series and would like to see it
> land [...]
Yeah, I would also really like to see it land :) Thanks to your last
rounds of review, I think we got to a much better design regarding
each grep case.
> [...] If we can't get more reviewers, maybe we just merge it down
> anyway? But, in an attempt to prod some review...
>
> Jonathan: I pinged you in chat about this series some time ago and you
> said you'd take a look and comment. I can't find a reference
> anywhere, but maybe you talked with Matheus in IRC somewhere? Do you
> recall?
>
> Matheus: Do you have any outstanding items for this series or is it
> good as far as you know?
Hm, I don't have anything else planned to add.
Just one minor aesthetic consideration: should we perhaps eliminate
the sparse-checkout.c file (and the accompanying header) from the last
patch? This file contains only one function; It was created with the
idea of being later populated by another parallel series [1]. However,
if we only have this function for now, should we move it elsewhere?
I'm not sure where, though. Maybe to config.c, together with
git_config_get_index_threads() and others?
[1]: https://lore.kernel.org/git/2188577cd848d7cee77f06f1ad2b181864e5e36d.1588857462.git.gitgitgadget@gmail.com/
next prev parent reply other threads:[~2020-08-29 4:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 21:43 What's cooking in git.git (Aug 2020, #07; Thu, 27) Junio C Hamano
2020-08-27 23:34 ` Jeff King
2020-08-27 23:36 ` Junio C Hamano
2020-08-28 0:39 ` Taylor Blau
2020-08-28 6:26 ` Jeff King
2020-08-28 8:31 ` Jeff King
2020-08-28 18:09 ` Taylor Blau
2020-08-28 2:16 ` Elijah Newren
2020-08-29 4:28 ` Matheus Tavares Bernardino [this message]
2020-08-28 15:48 ` ds/maintenance-part-[1-2] (was: What's cooking in git.git (Aug 2020, #07; Thu, 27)) Derrick Stolee
2020-08-28 20:09 ` What's cooking in git.git (Aug 2020, #07; Thu, 27) Hariom verma
2020-08-28 20:51 ` Junio C Hamano
2020-08-29 13:26 ` Hariom verma
2020-08-29 10:13 ` Hariom verma
2020-08-29 18:28 ` Junio C Hamano
2020-08-29 13:20 ` Hariom verma
2020-08-29 18:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHd-oW75wy07jo+pZzqjkzYekMWVSp0DmEVNQLG8GyTPNLZ1bQ@mail.gmail.com \
--to=matheus.bernardino@usp.br \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).