From: Matheus Tavares <matheus.bernardino@usp.br>
To: Joey Hess <id@joeyh.name>
Cc: git <git@vger.kernel.org>
Subject: Re: surprising value of LARGE_PACKET_MAX
Date: Thu, 4 Nov 2021 17:12:02 -0300 [thread overview]
Message-ID: <CAHd-oW6q67u=XGCGK=n25Kjph+ceuqPHLxQ0LH=Vydn4xctZ-A@mail.gmail.com> (raw)
In-Reply-To: <YYQtjWSb+z4taphX@kitenet.net>
On Thu, Nov 4, 2021 at 4:08 PM Joey Hess <id@joeyh.name> wrote:
>
> The docs don't say what the maximum size is, so I assumed I could make
> it as large as the length header allows, which I think is a natural
> conclusion to draw from the documentation. But looking in git's source,
> fff0 is the maximum:
>
> #define LARGE_PACKET_MAX 65520
> #define LARGE_PACKET_DATA_MAX (LARGE_PACKET_MAX - 4)
[...]
> Perhaps the best thing to do would be to document it in
> Documentation/technical/protocol-common.txt
Could it be that you consulted an older version of this file? The
current [1] version of the doc says:
"The maximum length of a pkt-line's data component is 65516 bytes.
Implementations MUST NOT send pkt-line whose length exceeds 65520
(65516 bytes of payload + 4 bytes of length data)."
[1]: https://github.com/git/git/blob/master/Documentation/technical/protocol-common.txt
next prev parent reply other threads:[~2021-11-04 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:59 surprising value of LARGE_PACKET_MAX Joey Hess
2021-11-04 20:12 ` Matheus Tavares [this message]
2021-11-05 14:57 ` Joey Hess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHd-oW6q67u=XGCGK=n25Kjph+ceuqPHLxQ0LH=Vydn4xctZ-A@mail.gmail.com' \
--to=matheus.bernardino@usp.br \
--cc=git@vger.kernel.org \
--cc=id@joeyh.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).