From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Johannes Sixt" <j6t@kdbg.org>, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2] test-lib: allow short options to be bundled
Date: Sat, 21 Mar 2020 19:42:49 -0300 [thread overview]
Message-ID: <CAHd-oW6V4cTpf4L-usGYEOMrn_VOY7ajMpBeLzfs_NTyi8pbxg@mail.gmail.com> (raw)
In-Reply-To: <xmqqtv2h8oac.fsf@gitster.c.googlers.com>
On Sat, Mar 21, 2020 at 5:07 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Matheus Tavares <matheus.bernardino@usp.br> writes:
>
> > +opt_required_arg=
> > +# $1: option string
> > +# $2: name of the var where the arg will be stored
> > +mark_option_requires_arg ()
> > +{
>
> "{" on the same line, just like you did for parse_option below.
Thanks. Will fix.
> > + if test -n "$opt_required_arg"
> > then
> > + echo "error: options that require args cannot be bundled" \
> > + "together: '$opt_required_arg' and '$1'" >&2
> > + exit 1
> > fi
> > + opt_required_arg=$1
> > + store_arg_to=$2
> > +}
> > +
> > +parse_option () {
> > + local opt="$1"
> > ...
> > + case "$opt" in
> > + --*)
> > + parse_option "$opt" ;;
>
> I think J6t's suggestion to the previous round still has merit here.
Yeah, I agree with your last reply that it makes the codeflow clearer.
I'll wait a bit to see if anyone else has other comments about this
iteration and then send v3 with both changes.
Thanks.
next prev parent reply other threads:[~2020-03-21 22:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 3:07 [PATCH] test-lib: allow short options to be stacked Matheus Tavares
2020-03-21 4:53 ` Junio C Hamano
2020-03-21 17:27 ` Matheus Tavares
2020-03-21 6:26 ` Jeff King
2020-03-21 18:50 ` Matheus Tavares Bernardino
2020-03-22 6:49 ` Jeff King
2020-03-22 8:14 ` SZEDER Gábor
2020-03-21 18:57 ` Junio C Hamano
2020-03-21 8:55 ` Johannes Sixt
2020-03-21 18:55 ` Matheus Tavares Bernardino
2020-03-21 20:11 ` Junio C Hamano
2020-03-21 19:57 ` [PATCH v2] test-lib: allow short options to be bundled Matheus Tavares
2020-03-21 20:07 ` Junio C Hamano
2020-03-21 22:42 ` Matheus Tavares Bernardino [this message]
2020-03-22 15:58 ` [PATCH v3] " Matheus Tavares
2020-03-23 20:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHd-oW6V4cTpf4L-usGYEOMrn_VOY7ajMpBeLzfs_NTyi8pbxg@mail.gmail.com \
--to=matheus.bernardino@usp.br \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).