From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 258C11F8C6 for ; Fri, 27 Aug 2021 22:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232414AbhH0Wvd (ORCPT ); Fri, 27 Aug 2021 18:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232289AbhH0Wvd (ORCPT ); Fri, 27 Aug 2021 18:51:33 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35218C0613D9 for ; Fri, 27 Aug 2021 15:50:43 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id k5so17491186lfu.4 for ; Fri, 27 Aug 2021 15:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fRscHGYgaA4YrdSn7ERAG9Qtn9lJwn5sN7zmnJ04ghY=; b=iM/EuNpafyebhvyFBgCKEhMS7ZLpMmS4FgulGTYevskREqEWjwol3kDp8SP2rBypmE 76y1RQLLrS8TZ5WLzPcE1QDyiYJn/qIjvw0aEyvwJEvmkuYR0UR2Bg6hEs6iALWfAfDQ tL8YjW2TtfrcC9eX2pT4m+6KcJaR+yWuC7Bifvz17KYpRamEUZN9Ih+PNF1adIiOI2y/ fzihH5UBRtAns5b4/sHZvhD+KCKQoluW4Ok+S907Yo1fOP9vZYENEuFTNOzkRxEoz23X OuLDdZSXqm6QO56+C1Flg071GskOkRP6biaOw5y+9RXyeGgPoYcN1AZx0FxqTua+yXj+ RsNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fRscHGYgaA4YrdSn7ERAG9Qtn9lJwn5sN7zmnJ04ghY=; b=S6A7Fd26R9j8mkMT+NHasbFEe3rLaZNzdxN1C1LRVjgF3872Po1TCQ+4vcC5BLoCH9 BSHpIM9NJuYeg0dEQHmPjenNzTIalL+vTQ2iA87kVK5oed4BsAeXHb18mEel6I+DiAbD CHVtcrsGi4p3ofE2FxasYL16kqNBlWJF7XuR5zam2TrmP9YK+Mg+DG9/5GdythD6TjsB y/xG2FED3vDkwhiduNXzLLGUZEeUacRx8hZVKyUDdiInmv1kREoo61zw7Tt2q46b9U6d RXEZW3BbXPB5pmy3ZBKiqT9hOleywc3wP4NthOxgnZLVauXaSfBepghDPhfIlnUZzBMk IZvA== X-Gm-Message-State: AOAM531b7SYUgrFwHVmgeJM8x8rPGc8IWB04vph+RLXSzK1rdyjDADU/ k6GuOGiRgbNHfd5x28KeuV8KFl/SHJFXuZzBhmzYRvQkmdJ2daRU X-Google-Smtp-Source: ABdhPJyaxBX5qmWNqwkhzbpKp+WMAHhy4vpKIamhdHRVwVIHrn2zttErrxdKBtBpFOJxnudiPVoBBHJeXmUz9w5GZQc= X-Received: by 2002:ac2:4e68:: with SMTP id y8mr8229584lfs.527.1630104641550; Fri, 27 Aug 2021 15:50:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Matheus Tavares Bernardino Date: Fri, 27 Aug 2021 19:50:30 -0300 Message-ID: Subject: Re: [PATCH 05/13] add: fail when adding an untracked sparse file To: Derrick Stolee via GitGitGadget Cc: git , Elijah Newren , Junio C Hamano , Derrick Stolee , Derrick Stolee , Derrick Stolee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Aug 27, 2021 at 6:06 PM Matheus Tavares Bernardino wrote: > > While I was playing with this patch, I did the following: > > echo a >a > echo b >b > git add . > git commit -m files > git sparse-checkout set a > echo c >c > git add c > > And the last `git add` was successful in adding the untracked `c` file > which is outside the sparse checkout. I'm not sure if I'm doing > something wrong, but it seems that `path_in_sparse_checkout()` returns > UNDECIDED for `c`. Is it because there was no pattern in the list > explicitly excluding it? And if so, should we consider UNDECIDED as > NOT_MATCHED for `path_in_sparse_checkout()`? Please disconsider this, It was my fault indeed. I had applied the patches onto the wrong base. Now I fetched them again but from the GGG tag, and my manual test worked as expected.