git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] git.c: fix sparse warning
Date: Tue, 2 Jun 2020 23:17:24 -0300	[thread overview]
Message-ID: <CAHd-oW5gaaH9Tn9Xq99AgH41N30Lr6N3n+GC2j1XUiNKyvAbdA@mail.gmail.com> (raw)
In-Reply-To: <d9686e75-0792-33f7-dd70-3dc8ca6c4d66@ramsayjones.plus.com>

On Mon, Jun 1, 2020 at 8:27 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>
> Commit 4acc44d720 (config: add setting to ignore sparsity patterns in
> some cmds, 2020-05-27) adds an external symbol definition without a
> corresponding external symbol declaration. This causes sparse to
> complain: "symbol 'opt_restrict_to_sparse_paths' was not declared.
> Should it be static?".
>
> In order to suppress the warning, #include the 'sparse-checkout.h'
> header file, which contains the required extern declaration.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Matheus,
>
> If you need to re-roll your 'mt/grep-sparse-checkout' branch, could you
> please squash this into the relevant patch.

Sure! Thanks for catching this.

      reply	other threads:[~2020-06-03  2:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01 23:27 [PATCH] git.c: fix sparse warning Ramsay Jones
2020-06-03  2:17 ` Matheus Tavares Bernardino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHd-oW5gaaH9Tn9Xq99AgH41N30Lr6N3n+GC2j1XUiNKyvAbdA@mail.gmail.com \
    --to=matheus.bernardino@usp.br \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).