mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matheus Tavares Bernardino <>
To: Christian Couder <>
Cc: git <>,
	"Оля Тележная" <>,
	"Thomas Gummerer" <>,
	"Elijah Newren" <>,
	"Rohit Ashiwal" <>,
	"Nguyễn Thái Ngọc Duy" <>
Subject: Re: [GSoC] My project blog
Date: Thu, 8 Aug 2019 11:22:51 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 6, 2019 at 4:16 AM Christian Couder
<> wrote:
> Hi Matheus,
> On Tue, Aug 6, 2019 at 4:54 AM Matheus Tavares Bernardino
> <> wrote:
> >
> > Here's my report from last week:
> >
> Thank you for another great report!
> > I'm working to protect the operations I left behind on the first
> > version of the patchset[1]. And for that, I used a lot of the code Duy
> > provided[2] me as an example in the early days of this project. The
> > race conditions are now majorly gone, but the patches still need some
> > refactoring and there are still some problems to overcome.
> This looks good to me! I think you are now way past the point where
> you know much more about this than me, but anyway the following might
> give you some ideas or perhaps in some other ways help you:
>   - About "Try to remove the obj_read_lock", which is the last point
> on your TODO list, it doesn't look necessary before you submit a patch
> series, unless there is no performance improvement without it. You
> could, as far as I can tell, do it in a later patch series.
>   - I guess " --recurse-submodules" is not used very often with git
> grep. For example I never use it on the Git repo even when I perhaps
> should. So if it would simplify things to just disable the
> improvements you made when " --recurse-submodules" is used, then you
> might consider doing that. You could later send another patch series
> that would enable your improvements when " --recurse-submodules" is
> used.

Thanks for the suggestions, Christian. So, I think I could finish and
send the patchset without the optimization for --recurse-submodules
and --textconv, while I don't finish support for them, right? And I
think 'obj_read_lock' may be removed in a future patch, as you said,
because we already have good speedup without removing it. Finally,
should I also add a "NOTES" section to Documentation/git-grep.txt
saying which options --threads is not compatible with?


  reply	other threads:[~2019-08-08 14:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-03  4:34 [GSoC] My project blog Matheus Tavares Bernardino
2019-07-14  7:38 ` Matheus Tavares Bernardino
2019-07-14 11:00   ` Christian Couder
2019-07-14 16:38     ` Matheus Tavares Bernardino
2019-07-23  1:13 ` Matheus Tavares Bernardino
2019-07-29 20:41 ` Matheus Tavares Bernardino
2019-08-06  2:54 ` Matheus Tavares Bernardino
2019-08-06  7:16   ` Christian Couder
2019-08-08 14:22     ` Matheus Tavares Bernardino [this message]
2019-08-13  4:06 ` Matheus Tavares Bernardino
2019-08-13 10:51   ` Christian Couder
2019-08-20  4:58 ` Matheus Tavares Bernardino
2019-08-20 11:27   ` Olga Telezhnaya
2019-08-20 12:16     ` Christian Couder
2019-08-20 22:41       ` Matheus Tavares Bernardino
2019-08-27  3:03 ` Matheus Tavares Bernardino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).