From: Matheus Tavares <matheus.bernardino@usp.br>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Jonathan Tan" <jonathantanmy@google.com>
Subject: Re: [PATCH] grep: demonstrate bug with textconv attributes and submodules
Date: Tue, 28 Sep 2021 14:18:34 -0300 [thread overview]
Message-ID: <CAHd-oW4fNNp+A_fFeqbTeOwDV+ss0-0x=rt0HOi2m1txrh+1ZQ@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cS1xrXHBbxwcwL_WKdnU9_MSTZffMtn3FxdUGuQX85XbA@mail.gmail.com>
On Tue, Sep 28, 2021 at 2:16 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Tue, Sep 28, 2021 at 1:08 PM Matheus Tavares
> <matheus.bernardino@usp.br> wrote:
> > In some circumstances, "git grep --textconv --recurse-submodules"
> > ignores the textconv attributes from the submodules and erroneuosly
> > apply the attributes defined in the superproject on the submodules'
> > files. The textconv cache is also saved on the superproject, even for
> > submodule objects.
>
> s/erroneuosly/erroneously/
>
> Also, perhaps: s/apply/applies/
>
> > Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
> > diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh
> > @@ -441,4 +441,107 @@ test_expect_success 'grep --recurse-submodules with --cached ignores worktree mo
> > +test_expect_failure 'grep --textconv corectly reads submodule .gitattributes' '
>
> Here and in remaining newly added tests: s/corectly/correctly/
>
> > +test_expect_failure 'grep saves textconv cache in the appropriated repository' '
>
> s/appropriated/appropriate/
Oops, I should have been more careful with the writing. Thanks for
catching those!
next prev parent reply other threads:[~2021-09-28 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 17:08 [PATCH] grep: demonstrate bug with textconv attributes and submodules Matheus Tavares
2021-09-28 17:15 ` Eric Sunshine
2021-09-28 17:18 ` Matheus Tavares [this message]
2021-09-28 17:16 ` Matheus Tavares
2021-09-29 12:24 ` [PATCH v2] " Matheus Tavares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHd-oW4fNNp+A_fFeqbTeOwDV+ss0-0x=rt0HOi2m1txrh+1ZQ@mail.gmail.com' \
--to=matheus.bernardino@usp.br \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).