From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jul 2019, #02; Tue, 9)
Date: Wed, 10 Jul 2019 21:02:08 -0300 [thread overview]
Message-ID: <CAHd-oW4-+XE_etXbDCvOX2Cdx1PcW-0oQWeq+jr=VPsf=EpgTg@mail.gmail.com> (raw)
In-Reply-To: <xmqq5zo9u36m.fsf@gitster-ct.c.googlers.com>
On Wed, Jul 10, 2019 at 3:58 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > Hi Junio,
> >
> > On Tue, 9 Jul 2019, Junio C Hamano wrote:
> >
> >> * mt/dir-iterator-updates (2019-06-25) 10 commits
> >> - clone: replace strcmp by fspathcmp
> >> - clone: use dir-iterator to avoid explicit dir traversal
> >> - clone: extract function from copy_or_link_directory
> >> - clone: copy hidden paths at local clone
> >> - dir-iterator: add flags parameter to dir_iterator_begin
> >> - dir-iterator: refactor state machine model
> >> - dir-iterator: use warning_errno when possible
> >> - dir-iterator: add tests for dir-iterator API
> >> - clone: better handle symlinked files at .git/objects/
> >> - clone: test for our behavior on odd objects/* content
> >>
> >> Adjust the dir-iterator API and apply it to the local clone
> >> optimization codepath.
> >>
> >> Is this ready for 'next'?
> >
> > I am afraid that still, just like I said in response to the previous
> > "What's cooking" mail, this is not ready (which is unsurprising, given
> > that it has not changed): it breaks 1,384 test cases.
>
> Let's kick it out of 'pu' for now to help ci runs on Windows, which
> would be swamped with failures from this. Thanks for reminding me.
Sorry for the delay. I just sent v8[1] with Dscho's suggestions, which
should fix all those test failures on Windows.
Thanks,
Matheus
[1]: https://public-inbox.org/git/cover.1562801254.git.matheus.bernardino@usp.br/
next prev parent reply other threads:[~2019-07-11 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 3:28 What's cooking in git.git (Jul 2019, #02; Tue, 9) Junio C Hamano
2019-07-10 18:51 ` Johannes Schindelin
2019-07-10 18:58 ` Junio C Hamano
2019-07-11 0:02 ` Matheus Tavares Bernardino [this message]
2019-07-11 17:28 ` Junio C Hamano
2019-07-10 18:59 ` jl/status-reduce-vertical-blank, was " Johannes Schindelin
2019-07-10 19:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHd-oW4-+XE_etXbDCvOX2Cdx1PcW-0oQWeq+jr=VPsf=EpgTg@mail.gmail.com' \
--to=matheus.bernardino@usp.br \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).