From: Sebastian Schuberth <sschuberth@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [BUG] fast-export --anonymize does not maintain fixup! commits
Date: Fri, 12 May 2017 11:39:29 +0200 [thread overview]
Message-ID: <CAHGBnuOXRdpyozq2BbLFnao6NB0GAL09bsQ-3NtDv6gZTpqvOA@mail.gmail.com> (raw)
In-Reply-To: <20170512092212.wpw232jfpp3bnqol@sigill.intra.peff.net>
On Fri, May 12, 2017 at 11:22 AM, Jeff King <peff@peff.net> wrote:
>> these (or any other command prefixes in commit messages). Given that
>> the --anonymize option is explicitly designed to help reproducing
>> bugs, I consider this to be a bug in the --anonymize option itself.
>
> Yes, it probably should handle those prefixes.
>
> I don't know if I'd call it a bug. Maybe a missing feature. :)
I'd usually agree, but in this case, as I mentioned above, I consider
the missing feature to be so essential that the oversight to implement
it is actually a bug :-)
> So this seems like a good example of that. I think I'd prefer to see us
> add in known prefixes like "fixup!" and "squash!" then try to guess what
> other prefixes might be OK. I don't know of any other command prefixes
> besides those two, so maybe that's all you were suggesting.
Those were also the only two that came to my mind, but I wanted to
give some one who has a better overview the change to amend that list.
> It shouldn't be too hard to add. You'd probably need to make two
> adjustments to anonymize_commit_message():
>
> 1. Teach it to store the mapping of anonymized messages, using
> anonymize_mem().
>
> 2. Parse "fixup! <msg>" and just anonymize_mem() the second half. I
> think technically this wouldn't handle a fixup-of-fixup, but I
> don't think rebase handles recursive ones anyway.
Thanks. I'll give it a try.
--
Sebastian Schuberth
prev parent reply other threads:[~2017-05-12 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 14:38 [BUG] fast-export --anonymize does not maintain fixup! commits Sebastian Schuberth
2017-05-12 9:22 ` Jeff King
2017-05-12 9:39 ` Sebastian Schuberth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHGBnuOXRdpyozq2BbLFnao6NB0GAL09bsQ-3NtDv6gZTpqvOA@mail.gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).