git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Aishwarya Narayanan <aishnana.03@gmail.com>
To: git@vger.kernel.org, karthik nayak <karthik.188@gmail.com>, ps@pks.im
Subject: GSoC 2024 [PATCH]
Date: Wed, 27 Mar 2024 15:05:57 +0530	[thread overview]
Message-ID: <CAHCXyj3Now+ZrA+w+L-sQAtAMZ8REru=3uF_Y3Xdt=7CSf=pYQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Dear Git Organization,

I hope this email finds you well. I've prepared a patch to address an
issue related to the handling of exit codes in our test suite
concerning the Microproject idea Avoid suppressing Git’s exit code in
test scripts. The changes ensure that the exit code of the write_utf16
and write_utf32 functions is properly captured and not suppressed,
improving the reliability of our testing process.
I kindly request your review and any remarks or changes you may have.
Please accept my apologies for any mistakes or oversights. Thank you
for your time and attention.

Best regards,
 Aishwarya Narayanan

[-- Attachment #2: t0028-working-tree-encoding.patch --]
[-- Type: application/octet-stream, Size: 1509 bytes --]

From 1493c834b2373226992d6c58f88549e7bc8dfd40 Mon Sep 17 00:00:00 2001
From: Aishwarya Narayanan <aishnana.03@gmail.com>
Date: Wed, 27 Mar 2024 14:47:40 +0530
Subject: [PATCH] The change ensures that the exit code of  write_utf16 and
 write_utf32 is properly captured and not suppressed.

---
 t/t0028-working-tree-encoding.sh | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/t/t0028-working-tree-encoding.sh b/t/t0028-working-tree-encoding.sh
index ad151a3467..f372c14bc0 100755
--- a/t/t0028-working-tree-encoding.sh
+++ b/t/t0028-working-tree-encoding.sh
@@ -19,10 +19,13 @@ test_expect_success 'setup test files' '
 	echo "*.utf16 text working-tree-encoding=utf-16" >.gitattributes &&
 	echo "*.utf16lebom text working-tree-encoding=UTF-16LE-BOM" >>.gitattributes &&
 	printf "$text" >test.utf8.raw &&
-	printf "$text" | write_utf16 >test.utf16.raw &&
-	printf "$text" | write_utf32 >test.utf32.raw &&
-	printf "\377\376"                         >test.utf16lebom.raw &&
-	printf "$text" | iconv -f UTF-8 -t UTF-16LE >>test.utf16lebom.raw &&
+	test_utf16_raw=$(printf "$text" | write_utf16) &&
+	test_utf32_raw=$(printf "$text" | write_utf32) &&
+	test_utf16lebom_raw=$(printf "\377\376"; printf "$text" | iconv -f UTF-8 -t UTF-16LE) &&
+	echo "$test_utf16_raw" > test.utf16.raw &&
+	echo "$test_utf32_raw" > test.utf32.raw &&
+	echo "$test_utf16lebom_raw" > test.utf16lebom.raw &&
+
 
 	# Line ending tests
 	printf "one\ntwo\nthree\n" >lf.utf8.raw &&
-- 
2.44.0.windows.1


             reply	other threads:[~2024-03-27  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  9:35 Aishwarya Narayanan [this message]
2024-03-27  9:47 ` GSoC 2024 [PATCH] Patrick Steinhardt
2024-03-27 15:23   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHCXyj3Now+ZrA+w+L-sQAtAMZ8REru=3uF_Y3Xdt=7CSf=pYQ@mail.gmail.com' \
    --to=aishnana.03@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).