From: Shaheed Haque <shaheedhaque@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: "add worktree" fails with "fatal: Invalid path" error
Date: Tue, 14 May 2019 15:48:08 +0100 [thread overview]
Message-ID: <CAHAc2jfZ7QvZ_PTZo5q8orSStZL2y8GJ=ZPe2-+hcydjEZ0=Ew@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8DnmQxO+r3ybg2zpCSMZJaTwc_C8V3QMCDjvga09sBigw@mail.gmail.com>
On Tue, 14 May 2019 at 13:34, Duy Nguyen <pclouds@gmail.com> wrote:
>
> On Mon, May 13, 2019 at 7:55 PM Shaheed Haque <shaheedhaque@gmail.com> wrote:
> > The original code used the more obvious "git worktree remove" rather
> > than "git worktree prune" but I switched partly because remove seemed
> > slow (I cannot now quantify what caused me to think that), and partly
> > because I was having other issues which, I now realise, you probably
> > addressed in your recent "stat versus mkdir race" change.
>
> It should be as slow as "git status; rm -r". The first command _could_
> be slow. But if you find it significantly slower than that, I will be
> glad to receive another bug report.
After I wrote, I went back and checked, and I have no idea why I
thought it slow. It seems just fine (by the time I have spawned out of
Python and all), and so I have switched the code back to
(synchronous/predictable) "git worktree remove".
Thanks, Shaheed
> --
> Duy
next prev parent reply other threads:[~2019-05-14 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 10:12 "add worktree" fails with "fatal: Invalid path" error Shaheed Haque
2019-05-13 9:20 ` Duy Nguyen
2019-05-13 12:55 ` Shaheed Haque
2019-05-14 12:33 ` Duy Nguyen
2019-05-14 14:48 ` Shaheed Haque [this message]
2019-05-13 10:49 ` [PATCH] worktree add: be tolerant of corrupt worktrees Nguyễn Thái Ngọc Duy
2019-05-13 12:42 ` Shaheed Haque
2019-05-17 7:46 ` Eric Sunshine
2019-05-18 11:49 ` Duy Nguyen
2019-06-01 19:29 ` Shaheed Haque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHAc2jfZ7QvZ_PTZo5q8orSStZL2y8GJ=ZPe2-+hcydjEZ0=Ew@mail.gmail.com' \
--to=shaheedhaque@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).