From: Jeffrey Walton <noloader@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: Re: Fix inet_ntop and inet_pton on Solaris
Date: Mon, 3 Feb 2020 19:00:43 -0500 [thread overview]
Message-ID: <CAH8yC8njDV9t+qF=EwFftVW5OkwKzaDMR-7ZGOBnqPbdt1R95A@mail.gmail.com> (raw)
In-Reply-To: <CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com>
On Mon, Feb 3, 2020 at 10:22 AM Jeffrey Walton <noloader@gmail.com> wrote:
>
> Hi Everyone,
>
> inet_ntop and inet_pton were not being detected properly on modern on
> Solaris. This patch revisits the the socket gear configuration on
> SunOS and brings it up to date for Solaris 11.
>
> According to configure.ac, the three or four functions of interest
> include hstrerror, inet_ntop and inet_pton. The libraries of interest
> are -lresolv -lsocket -lnsl. The configure tests now look for
> inet_ntop and inet_pton in -lsocket -lnsl per the man page. If not
> found, the configure tests fall back to existing behavior by searching
> in -lresolv. And if not found in -lresolv, then NO_INET_NTOP and
> NO_INET_PTON are set.
>
> Here's the configure fly-by:
>
> checking for socket... no
> checking for library containing socket... no
> checking for inet_ntop... no
> checking for library containing inet_ntop... -lnsl
> checking for inet_pton... yes
> checking for hstrerror... no
> checking for library containing hstrerror... -lresolv
>
> And config.status:
>
> $ /usr/gnu/bin/grep -E 'RESOLV|SOCKET|NSL' config.status
> NEEDS_RESOLV=YesPlease
> NEEDS_SOCKET=YesPlease
> NEEDS_NSL=YesPlease
The patch tested good on Linux (Ubuntu 18.04), Solaris 11 (SunOS 5.11)
and Darwin (OS X 10.9).
It is the same patch used for Git Master maint branch and Git 2.25.0
release tarball.
Jeff
next prev parent reply other threads:[~2020-02-04 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 15:22 Fix inet_ntop and inet_pton on Solaris Jeffrey Walton
2020-02-04 0:00 ` Jeffrey Walton [this message]
2020-02-14 6:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH8yC8njDV9t+qF=EwFftVW5OkwKzaDMR-7ZGOBnqPbdt1R95A@mail.gmail.com' \
--to=noloader@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).