From: Jon Seymour <jon.seymour@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [RFC] submodule: fix handling of supermodules with relative origin URLs.
Date: Sat, 19 May 2012 07:45:42 +1000 [thread overview]
Message-ID: <CAH3AnrqXbUuKKWzAf9_xHtu-c5sYGRf5dj+CqOmOmesnwh8=pg@mail.gmail.com> (raw)
In-Reply-To: <4FB6A9CB.5050702@web.de>
On Sat, May 19, 2012 at 5:58 AM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> This version of the patch does break some existing tests, but your
> follow up suggests you already found that out yourself ;-)
>
Actually, that was just by reading the patch and noticing odd-ness. I
realise now that I snuck in that bogus edit after I had run the tests
which were otherwise clean - d'oh.
>
> Me thinks up_path should be set in the case below, which is the only
> place where it is used.
Ok.
>
> Isn't sm_path already set correctly here? I think this line should
> be dropped.
>
Yes, good point. Thanks.
>
> Same here.
>
Thanks.
>
> Other than that the patch looks fine.
Thanks for the review - I'll add some tests for the new behaviour.
jon.
prev parent reply other threads:[~2012-05-18 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AH3Anrr6mLVedBPcgfVwy=5KRjUgdp5W8P0DQ3qaX_UjH-npDw@mail.gmail.com>
2012-05-18 12:13 ` [RFC] submodule: fix handling of supermodules with relative origin URLs Jon Seymour
2012-05-18 12:16 ` Jon Seymour
2012-05-18 19:58 ` Jens Lehmann
2012-05-18 21:45 ` Jon Seymour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH3AnrqXbUuKKWzAf9_xHtu-c5sYGRf5dj+CqOmOmesnwh8=pg@mail.gmail.com' \
--to=jon.seymour@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).