git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bryan Turner <bturner@atlassian.com>
To: David Carson <DCarson@extremenetworks.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: add 'ls-remote' option to limit output records
Date: Fri, 26 Apr 2019 12:32:51 -0700	[thread overview]
Message-ID: <CAGyf7-G+FEDVe=WiVVNJr1ALn-ryA4862qbjdDCNXM+LhpjORQ@mail.gmail.com> (raw)
In-Reply-To: <560CCADB-511B-495E-B86B-F294486C088C@contoso.com>

On Fri, Apr 26, 2019 at 11:57 AM David Carson
<DCarson@extremenetworks.com> wrote:
>
> Given that 'ls-remote' can be sorted, it would be useful to be able to ask for a subset of the total number of result records.
>
> For example, if I want to retrieve only the tag with the highest version, I would do so by adding this new option (-n1 in my example):
>
>         $ git ls-remote -n1 --tags --sort=v:refname origin "v*"
>
> That would save from having to receive a large list of tags from the remote, only one of which I care about.

That sort of filtering would have to be applied client side, at least
partially, so it wouldn't necessarily save as much as you'd hope.

With the v0/v1 wire protocol, the server speaks first and sends the
entire ref advertisement, so the filtering would have to be 100%
client side.

With the v2 wire protocol, the client could provide a prefix (like
`refs/tags/`, or potentially `refs/tags/v`) to reduce what the server
included in the ref advertisement, but even the v2 protocol doesn't
have anything for telling the server "Version parse these names and
then return the first N". That means the parsing, sorting and trimming
for the advertised tags would still all have to happen locally. (I'm
sure someone can correct me if I've misstated what protocol v2 can do
for filtering, but I don't see any "ls-refs" options that look like
they enable anything other than prefix matching.)

Not trying to imply any judgments on the feature request itself; I'm
just noting that if it was added it may not be quite the win you were
hoping for. In fact, with the existing wire protocol versions (all of
them), I suspect this would end up with identical bandwidth usage to:

$ git ls-remote --tags --sort=v:refname origin "v*" | head -1

It would take modifications to the wire protocol itself for this to
happen server-side, not just the `ls-remote` command.

Bryan

  reply	other threads:[~2019-04-26 19:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 18:56 add 'ls-remote' option to limit output records David Carson
2019-04-26 19:32 ` Bryan Turner [this message]
2019-05-01 18:23   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGyf7-G+FEDVe=WiVVNJr1ALn-ryA4862qbjdDCNXM+LhpjORQ@mail.gmail.com' \
    --to=bturner@atlassian.com \
    --cc=DCarson@extremenetworks.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).