git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Bryan Turner <bturner@atlassian.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git Users <git@vger.kernel.org>, "peff@peff.net" <peff@peff.net>,
	"gitster@pobox.com" <gitster@pobox.com>
Subject: Re: Split commit graphs and commit-graph read
Date: Mon, 11 Nov 2019 16:28:23 -0800	[thread overview]
Message-ID: <CAGyf7-EqQdvg4fQcZJv6BpqZ9hPDx72KBiLp1Xe3Ur7NrSMBeA@mail.gmail.com> (raw)
In-Reply-To: <87f16645-6af4-9703-1d0d-eb64728d2849@gmail.com>

On Sun, Nov 10, 2019 at 5:19 PM Derrick Stolee <stolee@gmail.com> wrote:
>
> > But git commit-graph read isn't:
> > .../objects$ git commit-graph read
> > fatal: Could not open commit-graph
> > '/path/to/repository/objects/info/commit-graph': No such file or
> > directory
> >
> > Running some tests with commands like git for-each-ref and git
> > rev-list shows that the "split" commit graph is being used (setting
> > core.commitGraph=false makes commands noticeably slower), so
> > functionally all seems well. But should git commit-graph read be
> > handling this better?
>
> Unfortunately, you're running into an issue because I designed the
> "read" subcommand poorly (and also forgot to update it for
> incremental commit-graph files). The biggest issue is that "read"
> is not really meant for end-users. It really should have been built
> as a test-tool. This point was corrected when I got around to writing
> the multi-pack-index since it uses "test-tool read-midx" instead of
> add.
>
> To fix this issue, I would probably go about it by removing the "read"
> subcommand and creating a "test-tool read-commit-graph" for the tests
> that need that output.
>
> If others on-list think that the better thing to do is to update the
> "read" subcommand to provide the same output, but iterate over each
> layer of an incremental commit-graph, then I can do that work instead.

I was only running "git commit-graph read" as another way of verifying
that everything looked good (to Git, that is). I'd already run "git
commit-graph verify" and just found the discrepancy in their behavior
surprising/interesting. For what it's worth, I personally don't see
anything amiss with removing the "read" subcommand if that's simpler
than updating it to handle incremental graphs. (Put differently, it's
not a command I'd ever have Bitbucket Server run, or that I'm likely
to try and run going forward. In this case I just completed some
commit graph-related changes to Bitbucket Server and was looking for
every possible avenue I could pursue to try and ensure what I did was
producing the "correct" output after my changes got deployed to our
internal dogfooding server.)

Thanks for taking the time to look into it and clarify the behavior! I
really appreciate it.

Best regards,
Bryan Turner

>
> Thanks,
> -Stolee

      parent reply	other threads:[~2019-11-12  0:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 23:41 Split commit graphs and commit-graph read Bryan Turner
2019-11-11  1:19 ` Derrick Stolee
2019-11-11  2:09   ` Junio C Hamano
2019-11-11  3:29   ` Jeff King
2019-11-12  0:28   ` Bryan Turner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGyf7-EqQdvg4fQcZJv6BpqZ9hPDx72KBiLp1Xe3Ur7NrSMBeA@mail.gmail.com \
    --to=bturner@atlassian.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).