From: Birger Skogeng Pedersen <birger.sp@gmail.com>
To: Git List <git@vger.kernel.org>
Subject: git-gui: duplicated key binds?
Date: Wed, 18 Sep 2019 13:24:40 +0200 [thread overview]
Message-ID: <CAGr--=KC=OPMJZB883MWys=J068cdZNHL=eOYK81fNBEv9MhvA@mail.gmail.com> (raw)
Hi,
It looks to me like there are a lot of key binds duplicated in the
git-gui source.
For instance, Ctrl/Cmd+Enter are bound in two lines:
bind $ui_comm <$M1B-Key-Return> {do_commit;break}
and
bind . <$M1B-Key-Return> do_commit
I guess the first one is specified to work in the commit message
widget. The second one is for all widgets(?).
Also, I see that some binds are with the "all" tag, while most are
with just a dot as tag.
Is this a mistake (aka something I could write a patch for)? Or am I
just missing something?
[0] https://github.com/prati0100/git-gui/blob/master/git-gui.sh#L3835-L3928
I propose:
- replace "bind . " with "bind all "
- remove duplicated bind entries, if a key is bound to "all" then it
shouldn't be bound with another tag
Birger
next reply other threads:[~2019-09-18 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 11:24 Birger Skogeng Pedersen [this message]
2019-09-18 16:17 ` git-gui: duplicated key binds? Birger Skogeng Pedersen
2019-09-18 20:46 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGr--=KC=OPMJZB883MWys=J068cdZNHL=eOYK81fNBEv9MhvA@mail.gmail.com' \
--to=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).