git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char
@ 2019-09-17 10:48 Birger Skogeng Pedersen
  2019-09-17 11:24 ` Birger Skogeng Pedersen
  0 siblings, 1 reply; 2+ messages in thread
From: Birger Skogeng Pedersen @ 2019-09-17 10:48 UTC (permalink / raw)
  To: Git List; +Cc: Pratyush Yadav

Hi,


I ran into som issues when compiling git-gui on Windows. Turns out
that the "sharedir" variable gets an incorrect value when "gitexecdir"
contains a space.

For instance when
gitexecdir is set to "/c/Program Files/Git/mingw64/libexec",
sharedir becomes "/c/ Files/Git/mingw64/share".

Perhaps it is me doing something wrong when setting the gitexecdir env
variable? I use
export gitexecdir=/c/Program\ Files/Git/mingw64/libexec

If that's a way to do it, should the Makefile be modified to derive
sharedir another way? Perhaps with a check if we're on a Windows
system.

What do you think?


Birger

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char
  2019-09-17 10:48 git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char Birger Skogeng Pedersen
@ 2019-09-17 11:24 ` Birger Skogeng Pedersen
  0 siblings, 0 replies; 2+ messages in thread
From: Birger Skogeng Pedersen @ 2019-09-17 11:24 UTC (permalink / raw)
  To: Git List; +Cc: Pratyush Yadav

Just saw this[0] issue discussed about GNU Make. It seems Make don't
play with path with spaces (at all). I guess my best solution is just
to make a symbolic link so there's a path without spaces.
I guess this issue can be ignored.

[0] http://savannah.gnu.org/bugs/?712

Best regards,
Birger

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-17 11:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 10:48 git-gui Makefile: cannot derive correct sharedir when gitexecdir has a space char Birger Skogeng Pedersen
2019-09-17 11:24 ` Birger Skogeng Pedersen

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).