From: Stefan Beller <sbeller@google.com>
To: Jeff King <peff@peff.net>
Cc: "Jonathan Tan" <jonathantanmy@google.com>,
"Brandon Williams" <bmwill@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Jacob Keller" <jacob.keller@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Ben Peart" <peartben@gmail.com>,
"Duy Nguyen" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Jeff Hostetler" <git@jeffhostetler.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 00/32] repository object
Date: Sun, 11 Jun 2017 22:24:12 -0700 [thread overview]
Message-ID: <CAGZ79kbtZJd3O1vZBEkqU5_VRs5LmJhxUKtWu4RWTyk5M1r__Q@mail.gmail.com> (raw)
In-Reply-To: <20170610060712.foqre5fscaxu3tnx@sigill.intra.peff.net>
On Fri, Jun 9, 2017 at 11:07 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jun 09, 2017 at 05:40:34PM -0700, Jonathan Tan wrote:
>
>> Before I get into the details, I have some questions:
>>
>> 1. I am concerned that "struct repository" will end up growing without
>> bounds as we store more and more repo-specific concerns in it. Could it
>> be restricted to just the fields populated by repo_init()?
>> repo_read_index() will then return the index itself, instead of using
>> "struct repository" as a cache. This means that code using
>> repo_read_index() will need to maintain its own variable holding the
>> returned index, but that is likely a positive - it's better for code to
>> just pass around the specific thing needed between functions anyway, as
>> opposed to passing a giant "struct repository" (which partially defeats
>> the purpose of eliminating the usage of globals).
>
> I think the repository object has to become a kitchen sink of sorts,
> because we have tons of global variables representing repo-wide config.
AFAICT we want to operate on struct 'the_repo' and struct 'the_cmd_options'
eventually. In our use case of submodules the submodules would ignore the
settings of the main repo, but still accept guidance of the_cmd_config or
'the_config.
> So I have a feeling that we're always going to need some
> big object to hold all that context when doing multi-repo operations in
> a single process.
Well not just one big struct, but two. (or more?)
next prev parent reply other threads:[~2017-06-12 5:24 UTC|newest]
Thread overview: 214+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 21:43 [PATCH 00/31] repository object Brandon Williams
2017-05-31 21:43 ` [PATCH 01/31] config: create config.h Brandon Williams
2017-05-31 21:43 ` [PATCH 02/31] config: don't include config.h by default Brandon Williams
2017-05-31 21:43 ` [PATCH 03/31] config: don't implicitly use gitdir Brandon Williams
2017-06-08 10:41 ` Johannes Schindelin
2017-06-08 16:37 ` Brandon Williams
2017-06-08 18:58 ` Johannes Schindelin
2017-06-08 19:19 ` Brandon Williams
2017-05-31 21:43 ` [PATCH 04/31] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-01 19:23 ` Stefan Beller
2017-06-02 18:39 ` Jeff King
2017-06-05 17:43 ` Brandon Williams
2017-06-05 18:20 ` Jeff King
2017-06-05 18:44 ` Brandon Williams
2017-05-31 21:43 ` [PATCH 05/31] environment: remove namespace_len variable Brandon Williams
2017-06-01 19:28 ` Stefan Beller
2017-06-01 21:09 ` Brandon Williams
2017-05-31 21:43 ` [PATCH 06/31] repo: introduce the repository object Brandon Williams
2017-06-01 19:53 ` Stefan Beller
2017-06-05 17:53 ` Brandon Williams
2017-06-05 18:31 ` Stefan Beller
2017-05-31 21:43 ` [PATCH 07/31] environment: place key repository state in the_repository Brandon Williams
2017-05-31 21:43 ` [PATCH 08/31] environment: store worktree " Brandon Williams
2017-05-31 21:43 ` [PATCH 09/31] setup: add comment indicating a hack Brandon Williams
2017-05-31 21:43 ` [PATCH 10/31] config: migrate the_configset to the_repository Brandon Williams
2017-05-31 21:43 ` [PATCH 11/31] repo: add index_state to struct repo Brandon Williams
2017-05-31 21:43 ` [PATCH 12/31] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-05-31 21:43 ` [PATCH 13/31] repo: add repo_read_gitmodules Brandon Williams
2017-05-31 21:44 ` [PATCH 14/31] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-05-31 21:44 ` [PATCH 15/31] convert: convert get_cached_convert_stats_ascii to take an index Brandon Williams
2017-05-31 21:44 ` [PATCH 16/31] convert: convert crlf_to_git " Brandon Williams
2017-05-31 21:44 ` [PATCH 17/31] convert: convert convert_to_git_filter_fd " Brandon Williams
2017-05-31 21:44 ` [PATCH 18/31] convert: convert convert_to_git " Brandon Williams
2017-05-31 21:44 ` [PATCH 19/31] convert: convert renormalize_buffer " Brandon Williams
2017-05-31 21:44 ` [PATCH 20/31] tree: convert read_tree to take an index parameter Brandon Williams
2017-05-31 21:44 ` [PATCH 21/31] ls-files: convert overlay_tree_on_cache to take an index Brandon Williams
2017-05-31 21:44 ` [PATCH 22/31] ls-files: convert write_eolinfo " Brandon Williams
2017-05-31 21:44 ` [PATCH 23/31] ls-files: convert show_killed_files " Brandon Williams
2017-05-31 21:44 ` [PATCH 24/31] ls-files: convert show_other_files " Brandon Williams
2017-05-31 21:44 ` [PATCH 25/31] ls-files: convert show_ru_info " Brandon Williams
2017-05-31 21:44 ` [PATCH 26/31] ls-files: convert ce_excluded " Brandon Williams
2017-05-31 21:44 ` [PATCH 27/31] ls-files: convert prune_cache " Brandon Williams
2017-05-31 21:44 ` [PATCH 28/31] ls-files: convert show_files " Brandon Williams
2017-05-31 21:44 ` [PATCH 29/31] ls-files: factor out debug info into a function Brandon Williams
2017-05-31 21:44 ` [PATCH 30/31] ls-files: factor out tag calculation Brandon Williams
2017-05-31 21:44 ` [PATCH 31/31] ls-files: use repository object Brandon Williams
2017-06-01 20:36 ` Stefan Beller
2017-06-05 17:46 ` Brandon Williams
2017-05-31 22:56 ` [PATCH 00/31] " Stefan Beller
2017-05-31 23:01 ` Brandon Williams
2017-06-01 18:10 ` Brandon Williams
2017-06-01 18:28 ` Stefan Beller
2017-06-01 20:03 ` Jacob Keller
2017-06-08 23:40 ` [PATCH v2 00/32] " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 01/32] config: create config.h Brandon Williams
2017-06-08 23:40 ` [PATCH v2 02/32] config: remove git_config_iter Brandon Williams
2017-06-08 23:40 ` [PATCH v2 03/32] config: don't include config.h by default Brandon Williams
2017-06-08 23:40 ` [PATCH v2 04/32] config: don't implicitly use gitdir Brandon Williams
2017-06-12 19:57 ` Brandon Williams
2017-06-08 23:40 ` [PATCH v2 05/32] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-08 23:40 ` [PATCH v2 06/32] environment: remove namespace_len variable Brandon Williams
2017-06-08 23:40 ` [PATCH v2 07/32] repository: introduce the repository object Brandon Williams
2017-06-09 8:53 ` [PATCH 0/2] Add a freez() wrapper Ævar Arnfjörð Bjarmason
2017-06-09 14:53 ` Brandon Williams
2017-06-09 22:04 ` [PATCH v2 0/2] Add a FREEZ() wrapper macro Ævar Arnfjörð Bjarmason
2017-06-09 22:04 ` [PATCH v2 1/2] git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL Ævar Arnfjörð Bjarmason
2017-06-09 22:27 ` Jonathan Nieder
2017-06-09 23:37 ` Eric Wong
2017-06-10 1:40 ` Junio C Hamano
2017-06-10 3:21 ` Eric Wong
2017-06-10 7:25 ` Jeff King
2017-06-15 16:48 ` Junio C Hamano
2017-06-15 17:13 ` Ævar Arnfjörð Bjarmason
2017-06-15 21:06 ` [PATCH v3 0/2] Add a FREE_AND_NULL() wrapper macro Ævar Arnfjörð Bjarmason
2017-06-15 22:00 ` Junio C Hamano
2017-06-15 23:15 ` [PATCH v4 0/6] " Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 1/6] git-compat-util: add a FREE_AND_NULL() wrapper around free(ptr); ptr = NULL Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 2/6] coccinelle: add a rule to make "type" code use FREE_AND_NULL() Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 3/6] coccinelle: make use of the "type" FREE_AND_NULL() rule Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL() Ævar Arnfjörð Bjarmason
2017-06-16 19:43 ` Junio C Hamano
2017-06-25 8:01 ` René Scharfe
2017-06-28 21:39 ` Ævar Arnfjörð Bjarmason
2017-06-28 22:00 ` Junio C Hamano
2017-06-28 22:17 ` Ævar Arnfjörð Bjarmason
2017-06-28 22:21 ` René Scharfe
2017-06-28 22:30 ` Ævar Arnfjörð Bjarmason
2017-06-28 23:15 ` Junio C Hamano
2017-06-28 22:30 ` René Scharfe
2017-06-28 22:35 ` Ævar Arnfjörð Bjarmason
2017-06-28 22:44 ` René Scharfe
2017-06-15 23:15 ` [PATCH v4 5/6] coccinelle: make use of the "expression" FREE_AND_NULL() rule Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 6/6] *.[ch] refactoring: make use of the FREE_AND_NULL() macro Ævar Arnfjörð Bjarmason
2017-06-15 21:06 ` [PATCH v3 1/2] git-compat-util: add a FREE_AND_NULL() wrapper around free(ptr); ptr = NULL Ævar Arnfjörð Bjarmason
2017-06-15 21:07 ` [PATCH v3 2/2] *.[ch] refactoring: make use of the FREE_AND_NULL() macro Ævar Arnfjörð Bjarmason
2017-06-10 6:55 ` [PATCH v2 1/2] git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL Andreas Schwab
2017-06-09 22:04 ` [PATCH v2 2/2] *.[ch] refactoring: make use of the FREEZ() macro Ævar Arnfjörð Bjarmason
2017-06-09 8:53 ` [PATCH 1/2] git-compat-util: add a freez() wrapper around free(x); x = NULL Ævar Arnfjörð Bjarmason
2017-06-09 12:04 ` Christian Couder
2017-06-09 8:53 ` [PATCH 2/2] *.[ch] refactoring: make use of the freez() wrapper Ævar Arnfjörð Bjarmason
2017-06-09 10:12 ` Martin Ågren
2017-06-09 10:58 ` Ævar Arnfjörð Bjarmason
2017-06-09 14:48 ` Brandon Williams
2017-06-08 23:40 ` [PATCH v2 08/32] environment: place key repository state in the_repository Brandon Williams
2017-06-08 23:40 ` [PATCH v2 09/32] environment: store worktree " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 10/32] setup: add comment indicating a hack Brandon Williams
2017-06-08 23:40 ` [PATCH v2 11/32] config: read config from a repository object Brandon Williams
2017-06-08 23:40 ` [PATCH v2 12/32] repository: add index_state to struct repo Brandon Williams
2017-06-08 23:40 ` [PATCH v2 13/32] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-06-08 23:40 ` [PATCH v2 14/32] submodule: add repo_read_gitmodules Brandon Williams
2017-06-08 23:40 ` [PATCH v2 15/32] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-06-08 23:40 ` [PATCH v2 16/32] convert: convert get_cached_convert_stats_ascii to take an index Brandon Williams
2017-06-08 23:40 ` [PATCH v2 17/32] convert: convert crlf_to_git " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 18/32] convert: convert convert_to_git_filter_fd " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 19/32] convert: convert convert_to_git " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 20/32] convert: convert renormalize_buffer " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 21/32] tree: convert read_tree to take an index parameter Brandon Williams
2017-06-08 23:40 ` [PATCH v2 22/32] ls-files: convert overlay_tree_on_cache to take an index Brandon Williams
2017-06-08 23:40 ` [PATCH v2 23/32] ls-files: convert write_eolinfo " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 24/32] ls-files: convert show_killed_files " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 25/32] ls-files: convert show_other_files " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 26/32] ls-files: convert show_ru_info " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 27/32] ls-files: convert ce_excluded " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 28/32] ls-files: convert prune_cache " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 29/32] ls-files: convert show_files " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 30/32] ls-files: factor out debug info into a function Brandon Williams
2017-06-08 23:40 ` [PATCH v2 31/32] ls-files: factor out tag calculation Brandon Williams
2017-06-08 23:41 ` [PATCH v2 32/32] ls-files: use repository object Brandon Williams
2017-06-09 0:08 ` Brandon Williams
2017-06-10 5:59 ` Junio C Hamano
2017-06-12 21:24 ` Brandon Williams
2017-06-10 0:40 ` [PATCH v2 00/32] " Jonathan Tan
2017-06-10 6:07 ` Jeff King
2017-06-10 6:13 ` Jeff King
2017-06-11 0:43 ` Brandon Williams
2017-06-12 19:10 ` Jonathan Tan
2017-06-11 0:35 ` Brandon Williams
2017-06-12 5:24 ` Stefan Beller [this message]
2017-06-12 21:23 ` Jeff King
2017-06-12 19:01 ` Jonathan Tan
2017-06-12 19:11 ` Brandon Williams
2017-06-12 20:04 ` Jonathan Tan
2017-06-12 21:28 ` Jeff King
2017-06-20 19:19 ` [PATCH v3 00/20] " Brandon Williams
2017-06-20 19:19 ` [PATCH v3 01/20] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-20 19:19 ` [PATCH v3 02/20] setup: add comment indicating a hack Brandon Williams
2017-06-20 19:19 ` [PATCH v3 03/20] environment: remove namespace_len variable Brandon Williams
2017-06-20 19:19 ` [PATCH v3 04/20] repository: introduce the repository object Brandon Williams
2017-06-20 19:57 ` Stefan Beller
2017-06-21 21:27 ` Brandon Williams
2017-06-21 21:31 ` Stefan Beller
2017-06-20 21:31 ` Jonathan Tan
2017-06-20 21:56 ` Brandon Williams
2017-06-20 19:19 ` [PATCH v3 05/20] environment: place key repository state in the_repository Brandon Williams
2017-06-20 21:59 ` Jonathan Tan
2017-06-20 19:19 ` [PATCH v3 06/20] environment: store worktree " Brandon Williams
2017-06-20 19:19 ` [PATCH v3 07/20] path: create path.h Brandon Williams
2017-06-20 19:19 ` [PATCH v3 08/20] path: always pass in commondir to update_common_dir Brandon Williams
2017-06-20 19:19 ` [PATCH v3 09/20] path: convert strbuf_git_common_path to take a 'struct repository' Brandon Williams
2017-06-20 19:19 ` [PATCH v3 10/20] path: convert do_git_path " Brandon Williams
2017-06-20 22:23 ` Jonathan Tan
2017-06-21 21:20 ` Brandon Williams
2017-06-20 19:19 ` [PATCH v3 11/20] path: construct correct path to a worktree's index Brandon Williams
2017-06-20 21:10 ` Stefan Beller
2017-06-20 23:02 ` Jonathan Nieder
2017-06-21 0:39 ` Brandon Williams
2017-06-21 2:10 ` Jonathan Nieder
2017-06-21 2:30 ` Jonathan Nieder
2017-06-21 15:43 ` Brandon Williams
2017-06-21 17:57 ` Jonathan Nieder
2017-06-21 18:48 ` Junio C Hamano
2017-06-20 19:19 ` [PATCH v3 12/20] path: add repo_git_path and strbuf_repo_git_path Brandon Williams
2017-06-20 19:19 ` [PATCH v3 13/20] path: add repo_worktree_path and strbuf_repo_worktree_path Brandon Williams
2017-06-20 19:19 ` [PATCH v3 14/20] config: read config from a repository object Brandon Williams
2017-06-20 19:19 ` [PATCH v3 15/20] repository: add index_state to struct repo Brandon Williams
2017-06-21 22:50 ` Jonathan Tan
2017-06-21 22:54 ` Brandon Williams
2017-06-21 23:00 ` Stefan Beller
2017-06-20 19:19 ` [PATCH v3 16/20] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-06-20 19:19 ` [PATCH v3 17/20] submodule: add repo_read_gitmodules Brandon Williams
2017-06-20 19:19 ` [PATCH v3 18/20] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-06-20 19:19 ` [PATCH v3 19/20] repository: enable initialization of submodules Brandon Williams
2017-06-21 23:00 ` Jonathan Tan
2017-06-21 23:09 ` Brandon Williams
2017-06-20 19:19 ` [PATCH v3 20/20] ls-files: use repository object Brandon Williams
2017-06-21 22:48 ` Jonathan Tan
2017-06-20 19:23 ` [PATCH v3 00/20] " Stefan Beller
2017-06-22 18:43 ` [PATCH v4 " Brandon Williams
2017-06-22 18:43 ` [PATCH v4 01/20] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-22 18:43 ` [PATCH v4 02/20] setup: add comment indicating a hack Brandon Williams
2017-06-22 18:43 ` [PATCH v4 03/20] environment: remove namespace_len variable Brandon Williams
2017-06-22 18:43 ` [PATCH v4 04/20] repository: introduce the repository object Brandon Williams
2017-06-22 18:43 ` [PATCH v4 05/20] environment: place key repository state in the_repository Brandon Williams
2017-06-22 18:43 ` [PATCH v4 06/20] environment: store worktree " Brandon Williams
2017-06-22 18:43 ` [PATCH v4 07/20] path: create path.h Brandon Williams
2017-06-22 18:43 ` [PATCH v4 08/20] path: always pass in commondir to update_common_dir Brandon Williams
2017-06-22 18:43 ` [PATCH v4 09/20] path: convert strbuf_git_common_path to take a 'struct repository' Brandon Williams
2017-06-22 18:43 ` [PATCH v4 10/20] path: convert do_git_path " Brandon Williams
2017-06-22 18:43 ` [PATCH v4 11/20] path: worktree_git_path() should not use file relocation Brandon Williams
2017-06-22 18:43 ` [PATCH v4 12/20] path: add repo_git_path and strbuf_repo_git_path Brandon Williams
2017-06-22 18:43 ` [PATCH v4 13/20] path: add repo_worktree_path and strbuf_repo_worktree_path Brandon Williams
2017-06-22 18:43 ` [PATCH v4 14/20] config: read config from a repository object Brandon Williams
2017-06-22 18:43 ` [PATCH v4 15/20] repository: add index_state to struct repo Brandon Williams
2017-06-22 20:16 ` Junio C Hamano
2017-06-22 20:35 ` Brandon Williams
2017-06-22 22:10 ` Junio C Hamano
2017-06-22 18:43 ` [PATCH v4 16/20] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-06-22 18:43 ` [PATCH v4 17/20] submodule: add repo_read_gitmodules Brandon Williams
2017-06-22 18:43 ` [PATCH v4 18/20] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-06-22 18:43 ` [PATCH v4 19/20] repository: enable initialization of submodules Brandon Williams
2017-06-22 18:43 ` [PATCH v4 20/20] ls-files: use repository object Brandon Williams
2017-06-22 19:42 ` [PATCH v4 00/20] " Stefan Beller
2017-06-23 16:44 ` Jeff Hostetler
2017-06-23 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kbtZJd3O1vZBEkqU5_VRs5LmJhxUKtWu4RWTyk5M1r__Q@mail.gmail.com \
--to=sbeller@google.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=bmwill@google.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).