From: Stefan Beller <firstname.lastname@example.org> To: Duy Nguyen <email@example.com> Cc: git <firstname.lastname@example.org> Subject: Re: submodule support in git-bundle Date: Fri, 2 Nov 2018 12:00:41 -0700 Message-ID: <CAGZ79kbrmec=SDYShkRN0Bz_zuBJnbw7+obxMCezjEFW==OUJQ@mail.gmail.com> (raw) In-Reply-To: <CACsJy8AZ=re0wAabHbRV0R7s-CUMJR8G6aeMx9cb++RvGY59Vg@mail.gmail.com> > > This offloading-to-CDN (or "mostly resumable clone" in the > > sense that the communication with the server is minimal, and > > you get most of your data via resumable http range-requests) > > sounds like complete offtopic, but is one of the requirements > > for the repo to submodule migration, hence I came to speak of it. > > Hm.. so what you're saying is, we could have a pack file that lists > other (real) pack files and for the bundle case they are all in the > same file. And "download from $THERE" in this case is "download at > this file offset"? That might actually work. We're conflating 2 things here. This idea of CDN offloading has nothing to do with submodules, it's just a general thing to improve the fetch protocol. And the pointed at file doesn't need to be a "real" packfile, as long as the bytestream at the end looks like a real packfile. For example the bytes to get from $THERE would not need to have a pack header (or if it had, I would ask you to omit the first bytes containing the header) as I can give the header myself. The idea for submodules is more along the lines of having "just" multiple pack files in the stream. For the bundle case we would probably not have redirection to $THERE in there, as it should be self contained completely (we don't know if the bundle recipient can access $THERE in a timely manner). > > Did you have other things in mind, on a higher level? > > e.g. querying the bundle and creating submodule bundles > > based off the superproject bundle? 'git bundle create' could > > learn the --recurse-submodules option, which then produces > > multiple bundle files without changing the file formats. > > This is probably the simplest way to support submodules. Yep, that sounds simplest, but I think it makes for bad UX. (Multiple files, need to be kept in some order and applied correctly) > I just > haven't really thought much about it (the problem just came up to me > like 2 hours ago). Two problems with this are convenience (I don't > want to handle multiple files) and submodule info (which pack should > be unbundled on which submodule?). But I suppose if "git bundle" > produces a tarball of these bundle files then you solve both. The tarball makes it one file and would naturally provide some order. It feels iffy, I'd rather have multiple packs in the bundle. > But of course there may be other and better options like what you > described above. If in long term we have "pack with hyperlinks" anyway > for resumable clone and other fancy stuff then reusing the same > mechanism for bundles makes sense, less maintenance burden. I think of the hyperlinks in packs as an orthogonal feature, but closely nearby in code and implementation, which is why I brought it up.
prev parent reply index Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-02 16:09 Duy Nguyen 2018-11-02 17:08 ` Stefan Beller 2018-11-02 18:34 ` Duy Nguyen 2018-11-02 19:00 ` Stefan Beller [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGZ79kbrmec=SDYShkRN0Bz_zuBJnbw7+obxMCezjEFW==OUJQ@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
firstname.lastname@example.org list mirror (unofficial, one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox