git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Alban Gruin <alban.gruin@gmail.com>
Cc: Phillip Wood <phillip.wood@dunelm.org.uk>,
	git <git@vger.kernel.org>,
	Christian Couder <christian.couder@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [GSoC][PATCH 0/2] rebase -i: rewrite append_todo_help() in C
Date: Thu, 31 May 2018 12:41:30 -0700	[thread overview]
Message-ID: <CAGZ79kbj=6FPHYR==kwWyv8DaA5SkhO6jGffAXOi=8Wcn5pL5Q@mail.gmail.com> (raw)
In-Reply-To: <2bf2d178-d286-c566-f68e-79c70fe66dbf@gmail.com>

On Thu, May 31, 2018 at 12:33 PM, Alban Gruin <alban.gruin@gmail.com> wrote:
> Hi Stefan,
>
> Le 31/05/2018 à 20:44, Stefan Beller a écrit :
>> On Thu, May 31, 2018 at 10:48 AM, Phillip Wood
>> <phillip.wood@talktalk.net> wrote:
>>> Hi Alban, it's great to see you working on this
>>>
>>> On 31/05/18 12:01, Alban Gruin wrote:
>>>> This series rewrites append_todo_help() from shell to C. This is part
>>>> of the effort to rewrite interactive rebase in C.
>>>>
>>>> The first commit rewrites append_todo_help() in C (the C version
>>>> covers a bit more than the old shell version), adds some parameters to
>>>> rebase--helper, etc.
>>>
>>> I've had a read of the first patch and I think it looks fine, my only
>>> comment would be that the help for '--edit-todo' is a bit misleading at
>>> the moment as currently it's just a flag to tell rebase-helper that the
>>> todo list is being edited rather than actually implementing the
>>> functionality to edit the list (but hopefully that will follow in the
>>> future).
>>
>> Would you have better suggestions for the name of the flag?
>> Of the top of my head:
>>   --write-edit-todo
>>   --hint-todo-edit
>>   --include-todo-edit-hint
>> not sure I like these names, though they seem to reflect the
>> nature of that flag a little bit better.
>>
>
> As my next patch series will probably be about rewriting edit-todo in C,
> do you really think I should rename the flag?

If you reroll, you could think of doing that. If you have the next series
prepared already that build on top, it may not be worth it.

>> If you feel strongly, I'd rather see Alban drop this second patch and
>> move on instead of waiting for our argument to settle. ( I do not feel
>> strongly about it, but put it out as a suggestion as that seemed like
>> it would lead to a better end state for the project).
>>
>
> Okay, so I drop this patch and reroll the other?

Sure, but maybe give Philip some time to react?

  reply	other threads:[~2018-05-31 19:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 11:01 [GSoC][PATCH 0/2] rebase -i: rewrite append_todo_help() in C Alban Gruin
2018-05-31 11:01 ` [GSoC][PATCH 1/2] rebase--interactive: " Alban Gruin
2018-05-31 11:01 ` [GSoC][PATCH 2/2] sequencer: remove newlines from append_todo_help() messages Alban Gruin
2018-05-31 17:48 ` [GSoC][PATCH 0/2] rebase -i: rewrite append_todo_help() in C Phillip Wood
2018-05-31 18:44   ` Stefan Beller
2018-05-31 19:33     ` Alban Gruin
2018-05-31 19:41       ` Stefan Beller [this message]
2018-06-01  9:44     ` Phillip Wood
2018-06-01 19:46       ` Stefan Beller
2018-05-31 19:25   ` Alban Gruin
2018-06-01  9:38     ` Phillip Wood
2018-06-05 12:53 ` [GSoC][PATCH v2 0/1] " Alban Gruin
2018-06-05 12:53   ` [GSoC][PATCH v2 1/1] rebase--interactive: " Alban Gruin
2018-06-07 10:30   ` [GSoC][PATCH v3 0/1] rebase -i: " Alban Gruin
2018-06-07 10:30     ` [GSoC][PATCH v3 1/1] rebase--interactive: " Alban Gruin
2018-06-26 16:16     ` [GSoC][PATCH v4 0/2] rebase -i: " Alban Gruin
2018-06-26 16:16       ` [GSoC][PATCH v4 1/2] sequencer: make two functions and an enum from sequencer.c public Alban Gruin
2018-06-26 21:41         ` Johannes Schindelin
2018-06-27 14:54           ` Alban Gruin
2018-06-26 16:16       ` [GSoC][PATCH v4 2/2] rebase--interactive: rewrite append_todo_help() in C Alban Gruin
2018-06-26 21:43         ` Johannes Schindelin
2018-06-26 21:37       ` [GSoC][PATCH v4 0/2] rebase -i: " Johannes Schindelin
2018-06-27 14:54         ` Alban Gruin
2018-06-28 10:04       ` [GSoC][PATCH v5 " Alban Gruin
2018-06-28 10:04         ` [GSoC][PATCH v5 1/2] sequencer: make two functions and an enum from sequencer.c public Alban Gruin
2018-06-28 10:04         ` [GSoC][PATCH v5 2/2] rebase--interactive: rewrite append_todo_help() in C Alban Gruin
2018-06-28 18:05         ` [GSoC][PATCH v5 0/2] rebase -i: " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGZ79kbj=6FPHYR==kwWyv8DaA5SkhO6jGffAXOi=8Wcn5pL5Q@mail.gmail.com' \
    --to=sbeller@google.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alban.gruin@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).