git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Sep 2017, #06; Fri, 29)
Date: Fri, 29 Sep 2017 10:27:33 -0700	[thread overview]
Message-ID: <CAGZ79kbh1kELT5nOJHAg8yZ-zp7vcxnxAGzXZ1nSPSX0qJoOrA@mail.gmail.com> (raw)
In-Reply-To: <5f7dbd81-ae27-c3a2-a14d-2832f71db1e9@gmail.com>

On Fri, Sep 29, 2017 at 6:08 AM, Derrick Stolee <stolee@gmail.com> wrote:
> Hi Junio,
>
> On 9/29/2017 12:34 AM, Junio C Hamano wrote:
>>
>> * ds/find-unique-abbrev-optim (2017-09-19) 4 commits
>>   - SQUASH???
>>   - sha1_name: parse less while finding common prefix
>>   - sha1_name: unroll len loop in find_unique_abbrev_r()
>>   - sha1_name: create perf test for find_unique_abbrev()
>
>
> I'll re-roll my patch on Monday if reviews have stabilized. I think I
> understand your comments this time (especially around 32-bit ints).
> Since I'm new to the list, I'm not sure what the change in messages
> means here.
>
> What does "SQUASH???" mean? Is that why there are three meaningful commits
> in this note, despite my five-commit patch? Would you like me to squash the
> commits in v3?

If you fetch from github/gitster/git, there is a branch
'ds/find-unique-abbrev-optim'
containing four commits; three by you, one by Junio. This one commit
is titled 'SQUASH???' as Junio did not want to write out what the
commit is doing
(e.g. fixing a typo, a memleak, or indentation or other small detail
that he observed)

You want to take the content of the commit and add it to one of yours,
where appropriate.

>
> Thanks,
> -Stolee

  reply	other threads:[~2017-09-29 17:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29  4:34 What's cooking in git.git (Sep 2017, #06; Fri, 29) Junio C Hamano
2017-09-29  6:34 ` Ian Campbell
2017-09-29 13:08 ` Derrick Stolee
2017-09-29 17:27   ` Stefan Beller [this message]
2017-10-01 23:09   ` Junio C Hamano
2017-10-02 10:26 ` Martin Ågren
2017-10-02 12:02   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kbh1kELT5nOJHAg8yZ-zp7vcxnxAGzXZ1nSPSX0qJoOrA@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).