From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH 0/6] Resend of origin/sb/submodule-update-in-c
Date: Wed, 18 Jul 2018 16:11:48 -0700 [thread overview]
Message-ID: <CAGZ79kbYybZ8KbaECy2oqrTH9dUKVgTfrrxbOYWxhF14_d210A@mail.gmail.com> (raw)
In-Reply-To: <xmqqpnzki3mp.fsf@gitster-ct.c.googlers.com>
On Wed, Jul 18, 2018 at 3:24 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Stefan Beller <sbeller@google.com> writes:
>
> > This fixes the compilation issue raised by SZEDER and Stolee,
> >
> >
> > 6: 3c156c79ae7 ! 6: f82f24e73b6 submodule--helper: introduce new update-module-mode helper
> > @@ -10,7 +10,6 @@
> > for arbitrary repositories.
> >
> > Signed-off-by: Stefan Beller <sbeller@google.com>
> > - Signed-off-by: Junio C Hamano <gitster@pobox.com>
> >
> > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> > --- a/builtin/submodule--helper.c
> > @@ -74,7 +73,7 @@
> > + determine_submodule_update_strategy(the_repository,
> > + just_cloned, path, update,
> > + &update_strategy);
> > -+ fprintf(stdout, submodule_strategy_to_string(&update_strategy));
> > ++ fputs(submodule_strategy_to_string(&update_strategy), stdout);
> > +
> > + return 0;
> > +}
> >
> > Thanks,
> > Stefan
>
> Thanks.
>
> This time not from GGG?
GGG = GitGitGadget?
I have yet to try out that tool, I am still stuck on git-send-email.
(old habits die hard)
It is even based off your branch (with all your sign offs).
I just cut down aggressively on the range diff (and short stat),
as I want to highlight the important part.
> I don't particularly care which direction
> patches come from, though ;-)
Cool.
Thanks,
Stefan
prev parent reply other threads:[~2018-07-18 23:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 19:48 [PATCH 0/6] Resend of origin/sb/submodule-update-in-c Stefan Beller
2018-07-18 19:48 ` [PATCH 1/6] git-submodule.sh: align error reporting for update mode to use path Stefan Beller
2018-07-18 19:48 ` [PATCH 2/6] git-submodule.sh: rename unused variables Stefan Beller
2018-07-18 19:48 ` [PATCH 3/6] builtin/submodule--helper: factor out submodule updating Stefan Beller
2018-07-18 19:48 ` [PATCH 4/6] builtin/submodule--helper: store update_clone information in a struct Stefan Beller
2018-07-18 19:48 ` [PATCH 5/6] builtin/submodule--helper: factor out method to update a single submodule Stefan Beller
2018-07-18 19:48 ` [PATCH 6/6] submodule--helper: introduce new update-module-mode helper Stefan Beller
2018-07-18 22:24 ` [PATCH 0/6] Resend of origin/sb/submodule-update-in-c Junio C Hamano
2018-07-18 23:11 ` Stefan Beller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kbYybZ8KbaECy2oqrTH9dUKVgTfrrxbOYWxhF14_d210A@mail.gmail.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).