From: Stefan Beller <sbeller@google.com>
To: Prathamesh Chavan <pc44800@gmail.com>
Cc: git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v1 0/5] Incremental rewrite of git-submodules: git-foreach
Date: Tue, 30 Jan 2018 12:37:01 -0800 [thread overview]
Message-ID: <CAGZ79kbVbUQGx84ynhG6DnOMNy4Qv1Og3ykRGqCNbNAswwnBfw@mail.gmail.com> (raw)
In-Reply-To: <20180129193453.3438-1-pc44800@gmail.com>
On Mon, Jan 29, 2018 at 11:34 AM, Prathamesh Chavan <pc44800@gmail.com> wrote:
> Following series of patches focuses on porting submodule subcommand
> git-foreach from shell to C.
> An initial attempt for porting was introduced about 9 months back,
> and since then then patches have undergone many changes. Some of the
> notable discussion thread which I would like to point out is: [1]
> The previous version of this patch series which was floated is
> available at: [2].
>
> The following changes were made to that:
> * As it was observed in other submodule subcommand's ported function
> that the number of params increased a lot, the variables quiet and
> recursive, were replaced in the cb_foreach struct with a single
> unsigned integer variable called flags.
>
> * To accomodate the possiblity of a direct call to the functions
> runcommand_in_submodule(), callback function
> runcommand_in_submodule_cb() was introduced.
>
> [1]: https://public-inbox.org/git/20170419170513.16475-1-pc44800@gmail.com/T/#u
> [2]: https://public-inbox.org/git/20170807211900.15001-14-pc44800@gmail.com/
>
> As before you can find this series at:
> https://github.com/pratham-pc/git/commits/patch-series-3
>
> And its build report is available at:
> https://travis-ci.org/pratham-pc/git/builds/
> Branch: patch-series-3
> Build #202
>
> Prathamesh Chavan (5):
> submodule foreach: correct '$path' in nested submodules from a
> subdirectory
> submodule foreach: document '$sm_path' instead of '$path'
> submodule foreach: clarify the '$toplevel' variable documentation
> submodule foreach: document variable '$displaypath'
> submodule: port submodule subcommand 'foreach' from shell to C
>
> Documentation/git-submodule.txt | 15 ++--
> builtin/submodule--helper.c | 151 ++++++++++++++++++++++++++++++++++++++++
> git-submodule.sh | 40 +----------
> t/t7407-submodule-foreach.sh | 38 +++++++++-
> 4 files changed, 197 insertions(+), 47 deletions(-)
Thanks for bringing this series up again, my review still holds.
Thanks,
Stefan
next parent reply other threads:[~2018-01-30 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180129193453.3438-1-pc44800@gmail.com>
2018-01-30 20:37 ` Stefan Beller [this message]
2018-02-02 5:00 ` [PATCH v1 0/5] Incremental rewrite of git-submodules: git-foreach Prathamesh Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kbVbUQGx84ynhG6DnOMNy4Qv1Og3ykRGqCNbNAswwnBfw@mail.gmail.com \
--to=sbeller@google.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pc44800@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).