git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Stefan Beller <sbeller@google.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] config.txt: reorder blame stuff to keep config keys sorted
Date: Sun, 5 Aug 2018 22:59:14 -0700	[thread overview]
Message-ID: <CAGZ79kbS7K0yUak9g5vH5ZyJ2aZ4RBmbBXHVtBzQjfRG4Fx1jg@mail.gmail.com> (raw)
In-Reply-To: <20180804062500.20188-1-pclouds@gmail.com>

On Fri, Aug 3, 2018 at 11:25 PM Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>
> The color group in config.txt is actually sorted but changes in
> sb/blame-color broke this. Reorder color.blame.* and move
> blame.coloring back to the rest of blame.* (and reorder that group too
> while we're there)
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

FWIW:
Acked-by: Stefan Beller <sbeller@google.com>

Are there more hidden sorts in the config.txt that I am not aware of?

Thanks for writing this patch!
Stefan

  reply	other threads:[~2018-08-06  5:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-04  6:25 [PATCH] config.txt: reorder blame stuff to keep config keys sorted Nguyễn Thái Ngọc Duy
2018-08-06  5:59 ` Stefan Beller [this message]
2018-08-06 15:35   ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGZ79kbS7K0yUak9g5vH5ZyJ2aZ4RBmbBXHVtBzQjfRG4Fx1jg@mail.gmail.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).