From: Stefan Beller <sbeller@google.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Paul Tan <pyokagan@gmail.com>
Subject: Re: [PATCH] am: add am.signoff add config variable
Date: Wed, 28 Dec 2016 09:45:24 -0800 [thread overview]
Message-ID: <CAGZ79kbRMYyaOmuqymx9dsLGdvX+iM9OMMQtQGS=uA+dO6_MVQ@mail.gmail.com> (raw)
In-Reply-To: <1482946838-28779-1-git-send-email-ehabkost@redhat.com>
On Wed, Dec 28, 2016 at 9:40 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> git-am has options to enable --message-id and --3way by default,
> but no option to enable --signoff by default. Add a "am.signoff"
> config option.
I think this is a good idea (from a design standpoint and what the user needs).
Just like e97a5e765d (git-am: add am.threeWay config variable), we'd
prefer if you'd
also update Documentation/config.txt as well as a new test. :)
Thanks,
Stefan
next prev parent reply other threads:[~2016-12-28 17:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 17:40 [PATCH] am: add am.signoff add config variable Eduardo Habkost
2016-12-28 17:45 ` Stefan Beller [this message]
2016-12-28 17:50 ` Eduardo Habkost
2016-12-29 8:47 ` Eric Wong
2016-12-29 15:45 ` Eduardo Habkost
2016-12-29 17:49 ` Jacob Keller
2016-12-29 21:42 ` Junio C Hamano
2016-12-29 22:16 ` Eduardo Habkost
2016-12-29 22:18 ` Stefan Beller
2016-12-29 22:43 ` Junio C Hamano
2016-12-29 23:34 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGZ79kbRMYyaOmuqymx9dsLGdvX+iM9OMMQtQGS=uA+dO6_MVQ@mail.gmail.com' \
--to=sbeller@google.com \
--cc=ehabkost@redhat.com \
--cc=git@vger.kernel.org \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).